Skip to content

Conversation

filipecosta90
Copy link
Collaborator

@filipecosta90 filipecosta90 commented May 17, 2021

This PR fixes #9 and removes all locking from the benchmark tool.

Removed all locking on stats updates
previous:

$ ./redis-benchmark-go -n 5000000 -c 50 -p 6379 set foo bar
Total clients: 50. Commands per client: 100000 Total commands: 5000000
Using random seed: 12345
                 Test time                    Total Commands              Total Errors                      Command Rate           p50 lat. (msec)
                       31s [100.0%]                   5000000                         0 [0.0%]                 159678.24                      0.30      
#################################################
Total Duration 31.000 Seconds
Total Errors 0
Throughput summary: 161288 requests per second
Latency summary (msec):
          p50       p95       p99
        0.299     0.428     0.626

current:

$ ./redis-benchmark-go -n 5000000 -c 50 -p 6379 set foo bar
Total clients: 50. Commands per client: 100000 Total commands: 5000000
Using random seed: 12345
                 Test time                    Total Commands              Total Errors                      Command Rate           p50 lat. (msec)
                       29s [100.0%]                   5000000                         0 [0.0%]                 106459.77                      0.29      
#################################################
Total Duration 29.001 Seconds
Total Errors 0
Throughput summary: 172407 requests per second
Latency summary (msec):
          p50       p95       p99
        0.287     0.369     0.564

@filipecosta90 filipecosta90 added the enhancement New feature or request label May 17, 2021
@filipecosta90 filipecosta90 changed the title Removed all locking on stats updates Removed all locking on stats updates and introduce 32-bit ARM packed bin May 17, 2021
@filipecosta90 filipecosta90 linked an issue May 17, 2021 that may be closed by this pull request
@filipecosta90 filipecosta90 merged commit e53b595 into master May 17, 2021
@filipecosta90 filipecosta90 deleted the no-locking branch May 17, 2021 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support to build ARM32 binary

1 participant