Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pushing to the git server requires Admin privileges #154

Closed
Richardk2n opened this issue Oct 22, 2024 · 2 comments
Closed

Pushing to the git server requires Admin privileges #154

Richardk2n opened this issue Oct 22, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@Richardk2n
Copy link

Richardk2n commented Oct 22, 2024 •
edited
Loading

I can clone and edit locally, however when I upload, I get a 403 error with my user having all privileges except Admin.
If I push using my root user it works.

For force pushing Admin should probably be required.
Otherwise, I would have expected upload to be sufficient.
@redimp redimp added the bug Something isn't working label Oct 22, 2024
@redimp
Copy link
Owner

redimp commented Oct 22, 2024

Bug confirmend. Reproduced it in the latest version. Will look into it asap. The ATTACHMENT/UPLOAD permission should users enable to push to the wiki.

redimp added a commit that referenced this issue Oct 23, 2024
@redimp
fix: has_permission must use self.has_permission to work correct with…
1b5368f 
… git

The bug in has_permission only affected authentication via http
basic auth that is used for authentication of git users.

The bug was found due to users with ATTACHMENT_ACCESS (Upload) permissions
were not able to do a 'git push' and was brought up in #154.
@redimp
Copy link
Owner

redimp commented Oct 23, 2024

Fix released in v2.7.0.

@redimp redimp closed this as completed Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@redimp @Richardk2n