This repository has been archived by the owner on Aug 21, 2024. It is now read-only.
scripts: Add the cid2civ script #562
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miyunari
reviewed
May 30, 2023
| @@ -74,3 +74,6 @@ repos: | |||
| hooks: | |||
| - id: interrogate | |||
| args: [--fail-under=60, --verbose] | |||
| # Unable to interrogate scripts without the .py extension: | |||
| # https://github.com/econchick/interrogate/issues/104 | |||
| files: \.(py)$ | |||
There was a problem hiding this comment.
Why do we need this? :) Can't we not add .py to the file instead?
| @@ -48,6 +48,7 @@ pre-commit = "^3.3.2" | |||
| ipython = "^8.13.2" | |||
| pytest-sugar = "^0.9.7" | |||
| rich = "^13.3.5" | |||
| docopt = "^0.6.2" | |||
|
|
|||
| [tool.poetry.scripts] | |||
| cloudimagedirectory-transformer = "cloudimagedirectory.transformer:run" | |||
There was a problem hiding this comment.
Does it make sense to register cid2civ here, the same way we did it with the transformer (and the old cli in the past)? :)
miyunari
approved these changes
Jun 8, 2023
Add a scripts that allows to download metadata about cloud images from Cloud Image Directory and prepare them for testing via Cloud Image Validation. * Print the supported arguments of the script: poetry run scripts/cid2civ --help * Download data about Azure images: poetry run scripts/cid2civ download azure > cid.json * Print a summary about the downloaded data: poetry run scripts/cid2civ analyze cid.json * Generate resources for the image validation: poetry run scripts/cid2civ convert cid.json > civ.json
Use local testdata using `--website file://$PWD/tests/scripts/testdata/website`.
Install docopt and requests-file as devel dependencies.
|
Update:
About Nina's suggestions, my idea was to keep the script (and any future scripts) separate from your source files and keep them language-agnostic, so you don't have to change the documentation and tests if necessary. Would it be fine to merge these changes as they are for now? You can always change it. |
|
For me that sounds good, @FKolwa what do you think? :) |
|
@miyunari Yes, I'm very fine with this! Feel free to merge ;) |
F-X64
approved these changes
Jun 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scripts that allows to download metadata about cloud images from Cloud Image Directory and prepare them for testing via Cloud Image Validation.
Print the supported arguments of the script:
poetry run scripts/cid2civ --helpDownload data about Azure images:
poetry run scripts/cid2civ download azure > cid.jsonPrint a summary about the downloaded data:
poetry run scripts/cid2civ analyze cid.jsonGenerate resources for the image validation:
poetry run scripts/cid2civ convert cid.json > civ.jsonTODO