-
Notifications
You must be signed in to change notification settings - Fork 43
removing deprecated preflight env in favor of PFLT_CERTIFICATION_COMPONENT_ID #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
from change #810:
|
📝 WalkthroughWalkthroughRenamed environment variable Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 51s |
|
retest |
|
from change #810: |
tonyskapunk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @acornett21
LGTM
…ONENT_ID Signed-off-by: Adam D. Cornett <[email protected]>
b51dc15 to
b8dd9c9
Compare
|
from change #810:
|
|
Build succeeded. ✔️ dci-rpm-build-el8 SUCCESS in 2m 55s |
…
SUMMARY
Updating preflight tasks to use non-deprecated env variable, since this will be removed in an upcoming release.
ISSUE TYPE
Tests
Test-hints: no-check