Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused package dependencies #97

Merged
merged 9 commits into from
Nov 10, 2023
Merged

remove unused package dependencies #97

merged 9 commits into from
Nov 10, 2023

Conversation

vishalvvr
Copy link
Contributor

  • Numpy removed in PR#94
  • We are installing PyYaml so pyyaml is not doing anything in specific
  • Cannot find any code using paho-mqtt package

@jhutar
Copy link
Contributor

jhutar commented Nov 8, 2023

Nice! Could you please remove numpy from core/setup.py as well?

And maybe also remove python3-numpy from Containerfile?

@vishalvvr vishalvvr added the cleanup Cleanup stale code, docs, config, etc. label Nov 8, 2023
@jhutar
Copy link
Contributor

jhutar commented Nov 8, 2023

Please fix linter errors (see https://github.com/redhat-performance/opl/actions/runs/6795933190/job/18474995543?pr=97) and I think we are good to go.

@vishalvvr vishalvvr marked this pull request as draft November 8, 2023 15:30
@jhutar jhutar marked this pull request as ready for review November 10, 2023 13:16
@jhutar jhutar merged commit 0b7c1d0 into redhat-performance:main Nov 10, 2023
1 check failed
@jhutar
Copy link
Contributor

jhutar commented Nov 10, 2023

Thank you Vishal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhutar jhutar jhutar approved these changes

Assignees
No one assigned
Labels
cleanup Cleanup stale code, docs, config, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishalvvr @jhutar