Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(status_data): Add missing deepdiff dependency numpy #138

Merged

Conversation

Smejky338
Copy link
Contributor

Got this error:

Traceback (most recent call last):
  File "/home/jenkins/workspace/InsightsInventoryXjoinlessPerfTest_runner/venv/bin/status_data.py", line 5, in <module>
    from opl.status_data import main
  File "/home/jenkins/workspace/InsightsInventoryXjoinlessPerfTest_runner/venv/src/opl-rhcloud-perf-team/opl/status_data.py", line 11, in <module>
    import deepdiff
  File "/home/jenkins/workspace/InsightsInventoryXjoinlessPerfTest_runner/venv/lib64/python3.12/site-packages/deepdiff/__init__.py", line 10, in <module>
    from .diff import DeepDiff
  File "/home/jenkins/workspace/InsightsInventoryXjoinlessPerfTest_runner/venv/lib64/python3.12/site-packages/deepdiff/diff.py", line 30, in <module>
    from deepdiff.distance import DistanceMixin, logarithmic_similarity
  File "/home/jenkins/workspace/InsightsInventoryXjoinlessPerfTest_runner/venv/lib64/python3.12/site-packages/deepdiff/distance.py", line 1, in <module>
    import numpy as np
ModuleNotFoundError: No module named 'numpy'

Tried to verify it fixes it by installing OPL in editable mode, entering python console and importing numpy and deepdiff. Both work.

Copy link
Contributor

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhutar jhutar merged commit 76c5b1e into redhat-performance:main Sep 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants