Fix skelet #127
Closed
Fix skelet #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- decouple StatusData class into another file, this was causing circular import. - update test for skelet - move get_now_str() function into date.py file - copy changes in opl dir into core/opl dir
|
After we merge this PR |
|
Looks great. Pls fix these linter errors (for now I'm perfectly OK to leave these "Clone found" ones in tests unfixed, but the other ones can be fixed easily I guess). Did the tests passed (see end of the readme on how to run them)? |
|
since @jhutar solved this issue, PR is not needed now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to fix
AttributeError: partially initialized module 'opl.skelet' has no attribute 'retry_on_traceback' (most likely due to a circular import)errors coming from skelet.py