Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more references to BM instead of MNO #604

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

akrzos
Copy link
Member

@akrzos akrzos commented Feb 5, 2025

No description provided.

@openshift-ci openshift-ci bot requested review from jtaleric and radez February 5, 2025 21:16
Copy link

openshift-ci bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrzos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@josecastillolema
Copy link
Collaborator

josecastillolema commented Feb 6, 2025

Looks good, and mostly documentation changes, however there seems to be a couple role name changes also.
Should we give it a pass in the CI jic?

@akrzos
Copy link
Member Author

akrzos commented Feb 11, 2025

/test ?

Copy link

openshift-ci bot commented Feb 11, 2025

@akrzos: The following commands are available to trigger required jobs:

/test deploy-5nodes
/test deploy-5nodes-dev
/test deploy-sno
/test deploy-sno-dev

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akrzos
Copy link
Member Author

akrzos commented Feb 11, 2025

/test deploy-5nodes

@akrzos
Copy link
Member Author

akrzos commented Feb 11, 2025

/test deploy-sno

@akrzos
Copy link
Member Author

akrzos commented Feb 11, 2025

Looks good, and mostly documentation changes, however there seems to be a couple role name changes also. Should we give it a pass in the CI jic?

Looks like Ci has shown it working for us. 😄

@josecastillolema
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 12, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 175e956 into redhat-performance:main Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants