Enable Assisted-installer to install CNV and LSO

[akrzos]

No description provided.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[akrzos]

Addresses #593

[akrzos]

/test deploy-5nodes

[akrzos]

Worked:

# oc get csv -A
NAMESPACE                              NAME                                          DISPLAY                    VERSION               REPLACES                                   PHASE
openshift-cnv                          kubevirt-hyperconverged-operator.v4.17.3      OpenShift Virtualization   4.17.3                kubevirt-hyperconverged-operator.v4.17.2   Succeeded
openshift-local-storage                local-storage-operator.v4.17.0-202501220934   Local Storage              4.17.0-202501220934                                              Succeeded
openshift-operator-lifecycle-manager   packageserver                                 Package Server             0.0.1-snapshot                                                   Succeeded
# oc get po -n openshift-cnv
NAME                                                   READY   STATUS    RESTARTS        AGE
aaq-operator-65fff5bfcc-h7rzq                          1/1     Running   0               3h28m
bridge-marker-6kj27                                    1/1     Running   0               3h28m
bridge-marker-b4mnd                                    1/1     Running   0               3h28m
bridge-marker-dbghm                                    1/1     Running   0               3h28m
bridge-marker-khv9b                                    1/1     Running   0               3h28m
bridge-marker-wt7b5                                    1/1     Running   0               3h28m
cdi-apiserver-6cd95c9db-7nscs                          1/1     Running   0               3h28m
cdi-deployment-d59f8869d-w4c69                         1/1     Running   0               3h28m
cdi-operator-7578474c7c-72np5                          1/1     Running   0               3h28m
cdi-uploadproxy-f76f9647-czl9h                         1/1     Running   0               3h28m
cluster-network-addons-operator-665dfc5bff-rxc9h       2/2     Running   0               3h29m
hco-operator-6f4b678cd4-nlk9x                          1/1     Running   0               3h29m
hco-webhook-6bc956cb84-2wrqn                           1/1     Running   0               3h29m
hostpath-provisioner-operator-cc8df8c7f-pln9f          1/1     Running   0               3h28m
hyperconverged-cluster-cli-download-664b4bc4f6-x877n   1/1     Running   0               3h29m
kube-cni-linux-bridge-plugin-79x5x                     1/1     Running   0               3h28m
kube-cni-linux-bridge-plugin-8l8fb                     1/1     Running   0               3h28m
kube-cni-linux-bridge-plugin-bp5bp                     1/1     Running   0               3h28m
kube-cni-linux-bridge-plugin-nx9gz                     1/1     Running   0               3h28m
kube-cni-linux-bridge-plugin-pd5wr                     1/1     Running   0               3h28m
kubemacpool-cert-manager-556f5648c7-vzfvc              1/1     Running   0               3h28m
kubemacpool-mac-controller-manager-8446dfb988-6ckwc    2/2     Running   0               3h28m
kubevirt-apiserver-proxy-756ccb9d47-7jqct              1/1     Running   0               3h27m
kubevirt-apiserver-proxy-756ccb9d47-9g5zz              1/1     Running   0               3h27m
kubevirt-console-plugin-74d95bbf5c-pcsqs               1/1     Running   0               3h27m
kubevirt-console-plugin-74d95bbf5c-zd6tl               1/1     Running   0               3h27m
ssp-operator-7746459ccf-7jjvf                          1/1     Running   1 (3h28m ago)   3h29m
virt-api-679ffdcb7d-k4klk                              1/1     Running   0               3h28m
virt-api-679ffdcb7d-r86vx                              1/1     Running   0               3h28m
virt-controller-5597f8b6-7jdds                         1/1     Running   0               3h27m
virt-controller-5597f8b6-h7pjx                         1/1     Running   0               3h27m
virt-exportproxy-6888775cbd-d2twp                      1/1     Running   0               3h27m
virt-exportproxy-6888775cbd-f775r                      1/1     Running   0               3h27m
virt-handler-fnxp4                                     1/1     Running   0               3h27m
virt-handler-zv92p                                     1/1     Running   0               3h27m
virt-operator-5c57846764-ppkrq                         1/1     Running   0               3h28m
virt-operator-5c57846764-rr849                         1/1     Running   0               3h28m
virt-template-validator-7c998df989-5jxzh               1/1     Running   0               3h27m
virt-template-validator-7c998df989-pg4hb               1/1     Running   0               3h27m

I'll default the var to false and move it to the all.yml

[akrzos]

/test deploy-5nodes

[akrzos]

FYI @josecastillolema another new variable in the all.yml this time for enabling cnv and lso install directly from assisted installer

[akrzos]

FYI @yobshans

[yobshans]

/lgtm

[openshift-ci]

@yobshans: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[akrzos]

@josecastillolema Looks like the CI does not copy the all.sample.yml and modify, it just uses it own since this test failed:

TASK [install-cluster : Enable CNV and LSO install] ****************************
Wednesday 29 January 2025  10:50:31 -0500 (0:00:00.426)       0:10:36.206 ***** 
fatal: [y37-h15-000-r740xd.rdu3.labs.perfscale.redhat.com]: FAILED! => {"msg": "The conditional check 'enable_cnv_install' failed. The error was: error while evaluating conditional (enable_cnv_install): 'enable_cnv_install' is undefined\n\nThe error appears to be in '/tmp/jetlag-performancelab-cloud19-1738164989/ansible/roles/install-cluster/tasks/main.yml': line 23, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Enable CNV and LSO install\n  ^ here\n"}

Did we want to switch it to copying and then modifying so it better represents how the docs mention to use jetlag?

[akrzos]

/test deploy-5nodes

[akrzos]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrzos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [akrzos]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[radez]

/lgtm

[josecastillolema]

@josecastillolema Looks like the CI does not copy the all.sample.yml and modify, it just uses it own since this test failed:

TASK [install-cluster : Enable CNV and LSO install] ****************************
Wednesday 29 January 2025  10:50:31 -0500 (0:00:00.426)       0:10:36.206 ***** 
fatal: [y37-h15-000-r740xd.rdu3.labs.perfscale.redhat.com]: FAILED! => {"msg": "The conditional check 'enable_cnv_install' failed. The error was: error while evaluating conditional (enable_cnv_install): 'enable_cnv_install' is undefined\n\nThe error appears to be in '/tmp/jetlag-performancelab-cloud19-1738164989/ansible/roles/install-cluster/tasks/main.yml': line 23, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: Enable CNV and LSO install\n  ^ here\n"}

Did we want to switch it to copying and then modifying so it better represents how the docs mention to use jetlag?

You are correct, we just create a new all.yml file (https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift-qe/installer/bm/deploy/openshift-qe-installer-bm-deploy-commands.sh#L18-L43).
I think copying it and modifying will be better, do you have some cycles to help with that?

Thanks

[josecastillolema]

FYK @jtaleric , should we deprecate our current CNV deploy (https://github.com/openshift/release/blob/master/ci-operator/step-registry/openshift-qe/installer/bm/day2/cnv/openshift-qe-installer-bm-day2-cnv-commands.sh) in favor of this method? Wdyt?