Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuing work for #352 (Removing multiple SNO complexity) + split D… #597

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

akrzos
Copy link
Member

@akrzos akrzos commented Jan 27, 2025

…U Profile into seperate files for easier maintenance

Copy link

openshift-ci bot commented Jan 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@akrzos
Copy link
Member Author

akrzos commented Jan 28, 2025

/test deploy-sno

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch 2 times, most recently from f362007 to 3bd5e6e Compare January 28, 2025 14:55
@akrzos
Copy link
Member Author

akrzos commented Jan 28, 2025

/test deploy-sno

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from 3bd5e6e to 5049c84 Compare January 28, 2025 16:02
@akrzos
Copy link
Member Author

akrzos commented Jan 28, 2025

/test deploy-sno

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from 5049c84 to 2423d53 Compare January 28, 2025 18:25
@akrzos
Copy link
Member Author

akrzos commented Jan 28, 2025

/test deploy-sno

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from 2423d53 to cca9405 Compare January 28, 2025 20:22
@akrzos
Copy link
Member Author

akrzos commented Jan 28, 2025

/test deploy-sno

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from cca9405 to e83269a Compare January 28, 2025 21:34
@akrzos
Copy link
Member Author

akrzos commented Jan 29, 2025

/test deploy-sno

@akrzos
Copy link
Member Author

akrzos commented Jan 29, 2025

# oc get no
NAME                 STATUS   ROLES                         AGE   VERSION
y37-h17-000-r740xd   Ready    control-plane,master,worker   9h    v1.30.7

I think the CI health check may need to be different for SNOs. WDYT @josecastillolema

@akrzos akrzos marked this pull request as ready for review January 29, 2025 15:36
@openshift-ci openshift-ci bot requested review from jtaleric and radez January 29, 2025 15:36
@josecastillolema
Copy link
Collaborator

I think the CI health check may need to be different for SNOs. WDYT @josecastillolema

Yeah it is broken because it expects a public vlan SNO deployment.
Let me disable it for now, and then we can implement a proper alternative:

  • Implement the health check within jetlag playbooks
  • Finish the public vlan setup for SNOs that @rsevilla87 was working on

Keep you posted

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch 5 times, most recently from f8ff988 to 0babbf9 Compare February 5, 2025 13:33
@josecastillolema
Copy link
Collaborator

/test ?

Copy link

openshift-ci bot commented Feb 5, 2025

@josecastillolema: The following commands are available to trigger required jobs:

/test deploy-5nodes
/test deploy-5nodes-dev
/test deploy-sno
/test deploy-sno-dev

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from 0babbf9 to 171416f Compare February 5, 2025 16:45
…plexity) + split DU Profile into seperate files for easier maintenance
@akrzos akrzos force-pushed the finish_sno_352_pt1 branch from 171416f to a4528f8 Compare February 5, 2025 18:21
@akrzos
Copy link
Member Author

akrzos commented Feb 5, 2025

/test deploy-sno

@akrzos
Copy link
Member Author

akrzos commented Feb 5, 2025

The SNO has deployed successfully:

# oc get clusterversion
NAME      VERSION   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.17.15   True        False         17m     Cluster version is 4.17.15

@akrzos
Copy link
Member Author

akrzos commented Feb 5, 2025

/test deploy-5nodes

Copy link

openshift-ci bot commented Feb 5, 2025

@akrzos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/deploy-sno a4528f8 link true /test deploy-sno

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@akrzos
Copy link
Member Author

akrzos commented Feb 6, 2025

/approve

Copy link

openshift-ci bot commented Feb 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: akrzos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akrzos akrzos merged commit 676c38b into redhat-performance:main Feb 6, 2025
1 of 3 checks passed
@akrzos akrzos deleted the finish_sno_352_pt1 branch February 6, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants