Skip to content

chore(fullsend): change models for agents #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnStrunk merged 1 commit into from
Sep 10, 2026
Merged

chore(fullsend): change models for agents #89

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 28 additions & 3 deletions .fullsend/config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ roles:
- fix
- retro
- prioritize
agents:
- name: triage
source: harness/triage.yaml
allowed_remote_resources:
- https://raw.githubusercontent.com/fullsend-ai/fullsend/
- https://raw.githubusercontent.com/fullsend-ai/agents/
Expand All @@ -28,6 +25,34 @@ create_issues:
- redhat-et/ProtoBot
- fullsend-ai/fullsend
- fullsend-ai/agents
# Fullsend itself is pinned to sonnet 4.6. This changes what the `sonnet` alias means.
models:
aliases:
sonnet: claude-sonnet-5
agents:
- name: code

@fullsend-ai-review fullsend-ai-review Bot Sep 10, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[medium] logic-error

The roles list includes coder (line 14), but the agents block defines an agent named code (line 33). Every other role-to-agent pairing in this file uses an exact name match (fix/fix, prioritize/prioritize, review/review, retro/retro, triage/triage), and the pre-existing base branch also used an exact match (triage role to triage agent). The code/coder mismatch is the sole exception, strongly suggesting it is unintentional. If fullsend resolves agent config by name match, the model (xai/grok-4.6) and runtime (pi) overrides for the code agent will not apply to the coder role.

Suggested fix: Rename the agent to name: coder to match the declared role, or change the role from coder to code. Given that every other entry uses exact name matching, aligning the agent name to the role (name: coder) is the safest fix.

@tumido tumido Sep 10, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct according to https://fullsend.sh/docs/guides/user/bring-your-own-agent#minimum-viable-agent

Cite:

role is not the agent's name. The agent's name is name: in its .md; role: selects which GitHub App and permissions the mint issues. On the default (hosted) mint, role: must be one of the built-in roles it serves — triage, coder, review, retro, prioritize, fullsend. Pick the one whose permissions fit what your agent does (a code-writing agent uses role: coder). A made-up role like role: my-agent returns 403 from the mint. To use a new role or your own identity, you need your own mint — see [Custom Agent Identity](https://fullsend.sh/docs/guides/user/custom-agent-identity).

runtime: pi
model: xai/grok-4.6
- name: fix
runtime: pi
model: google-vertex/gemini-3.8-flash
- name: prioritize
runtime: pi
model: google-vertex/gemini-3.8-flash
- name: review
runtime: pi
model: sonnet
subagents:
challenger: xai/grok-4.6
correctness: xai/grok-4.6
docs-currency: google-vertex/gemini-3.8-flash
security: xai/grok-4.6
style-conventions: google-vertex/gemini-3.8-flash
- name: retro
model: sonnet
- name: triage
model: sonnet
source: harness/triage.yaml
inference:
project: it-gcp-octo-fullsend
wif_provider: projects/554959098399/locations/global/workloadIdentityPools/fullsend-inference/providers/gh-redhat-et-protobot
Expand Down
Loading