added ipv4 and ipv6 validation

[msivasubramaniaan]

Signed-off-by: msivasubramaniaan [email protected]

The existing PR has some issues due to my local reabase, Hence created a new one

What does this PR do?

Added IPv4 and IPv6 format validation on parser

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#832

Is it tested? How?

Yes added UT

[coveralls]

Coverage: 83.243% (+0.2%) from 83.063% when pulling 2fea951 on 832-format-ipv4-is-not-being-checked into 9d71bbf on main.

[rgrunber]

When I have something like :

{
    "type": "array",
    "items": {
      "type": "string",
      "format": "ipv6"
    }
}

[
"2001:0db8:85a3:0000:0000:8a2e:0370:7334",
"2001:0db8:85a3:0000:0000:8a2e:0370:7334"
]

and associate the schema with the file, one of the entires doesn't validate.

Update: This is definitely a bug. In fact the root cause is the regular expression used for the ipv4/ipv6 patterns. You've included a flag for your particular pattern that will results in some unpredictable behaviour.

[msivasubramaniaan]

When I have something like :

{
    "type": "array",
    "items": {
      "type": "string",
      "format": "ipv6"
    }
}

[
"2001:0db8:85a3:0000:0000:8a2e:0370:7334",
"2001:0db8:85a3:0000:0000:8a2e:0370:7334"
]

and associate the schema with the file, one of the entires doesn't validate.

Update: This is definitely a bug. In fact the root cause is the regular expression used for the ipv4/ipv6 patterns. You've included a flag for your particular pattern that will results in some unpredictable behaviour.

@rgrunber
Agree. That happened due to multi-line flag. Updated the regex pattern and added all the scenarios on the test case for better coverage.

[rgrunber]

Overall looks good, so once the last comments are addressed, I thin this is good to squash + merge.