Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merged the hover results #772

Merged
merged 4 commits into from
Sep 18, 2022
Merged

Conversation

msivasubramaniaan
Copy link
Contributor

What does this PR do?

This PR append the title and description of anyOf schemas while hover

What issues does this PR fix or reference?

redhat-developer/vscode-yaml#784

Is it tested? How?

Yes. added UT

@coveralls
Copy link

coveralls commented Aug 29, 2022

Coverage Status

Coverage increased (+0.1%) to 83.063% when pulling cf7a7cf on fix-append-results-on-hover into 47290fe on main.

@msivasubramaniaan msivasubramaniaan self-assigned this Aug 29, 2022
Copy link
Collaborator

@gorkem gorkem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is somehow causing one of the schemaValidation.ts tests to fail. I can see it locally and on CI too.

@msivasubramaniaan
Copy link
Contributor Author

This is somehow causing one of the schemaValidation.ts tests to fail. I can see it locally and on CI too.

The test case was failed due to the recent changes happened on github-workflow.json

FYR
image

@gorkem
Copy link
Collaborator

gorkem commented Sep 18, 2022

also fixes #779

@msivasubramaniaan msivasubramaniaan merged commit 220519d into main Sep 18, 2022
@msivasubramaniaan msivasubramaniaan deleted the fix-append-results-on-hover branch September 18, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants