Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemas through files.association settings are enabled #714

Merged
merged 1 commit into from
May 18, 2022

Conversation

gorkem
Copy link
Collaborator

@gorkem gorkem commented May 16, 2022

When a file is associated using file.associations setting with YAML language, any schemas that correspond to the association are enabled to be used from the schema store.

What issues does this PR fix or reference?

Fixes redhat-developer/vscode-yaml#747
Fixes redhat-developer/vscode-yaml#701

Is it tested? How?

Adds 3 test cases

When a file is associated  (file.associations setting)
with yaml language any schemas
that correspond to the association are enabled to be
used from schema store.
@gorkem gorkem requested a review from msivasubramaniaan as a code owner May 16, 2022 21:06
@gorkem gorkem requested a review from evidolob May 16, 2022 21:11
@ssbarnea ssbarnea added the bug label May 18, 2022
@ssbarnea ssbarnea changed the title schemas through files.association settings are enabled Schemas through files.association settings are enabled May 18, 2022
Copy link
Contributor

@msivasubramaniaan msivasubramaniaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ssbarnea ssbarnea merged commit 417a68e into redhat-developer:main May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Schema from catalog.json in ui JSON Schema not applied for custom file extension
3 participants