Expose only pullConfiguration as API #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the SettingsHandler and exposes only pullConfiguration as API. This makes it easy to keep a consistent Settings list which would otherwise be affected from multiple events causing race conditions. Also modifies the tests to test through pullConfiguration.
msivasubramaniaan
approved these changes
Mar 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the
SettingsHandlerand exposes onlypullConfigurationas API. This makes it easy to keep a consistent Settings list which would otherwise be affected by multiple events causing race conditions.Also modifies the tests to test through
pullConfiguration.What issues does this PR fix or reference?
fixes redhat-developer/vscode-yaml#721
Is it tested? How?
Added a new case to cover schema store and modified existing tests.