Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: completion invoke in three different scenarios #617

Conversation

p-spacek
Copy link
Contributor

What does this PR do?

fix: completion invoke in three different scenarios

  1. with short nextLine - nested object
  2. with a new line inside the object
  3. on the first array item

  1. when the cursor is closer to the next element than the previous one
example:
  sample:
    # cursore here
  a: test # 'a' is closer to the curseor then 'sample'
  1. when the cursor is on the first line just inside the object
example:
  sample:
    # cursore here
    prop: test
  1. when the cursor is on the first item array position
examples:
  # cursore here
  - sample:
       prop: test

What issues does this PR fix or reference?

no ref

Is it tested? How?

added unit tests

 - with short nextLine - nested object
 - with a new line inside the object
 - on the first array item
@coveralls
Copy link

coveralls commented Dec 10, 2021

Coverage Status

Coverage increased (+0.1%) to 79.086% when pulling b32f6d8 on p-spacek:fix/completion-invoke-in-specail-cases into 2c86c8b on redhat-developer:main.

@evidolob evidolob merged commit 29376f2 into redhat-developer:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants