feat: add option to specify custom schema store #459
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catthehacker
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
evidolob
approved these changes
May 18, 2021
JPinkney
approved these changes
May 18, 2021
joshuawilson
approved these changes
May 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds option to specify custom schema store schema
What issues does this PR fix or reference?
redhat-developer/vscode-yaml#294
redhat-developer/vscode-yaml#406
Is it tested? How?
This change is published here: https://www.npmjs.com/package/@hackercat/yaml-language-server (with few changes in tests and my own schema store mirror) since I've tested it few times with custom store and clearing cache.
I think that the change is fairly small and easy to review. I'd appreciate any pointers since I never had any experience (except JS) with NodeJS/TS/NPM/etc. before and this whole thing was hacked in few hours (90% of time trying to figure out how to build this whole thing with
vscode-yamlextension, it was a lot ofyarn this,yarn that, I've not runyarn testforvscode-yamlextension sincevscodebreaks on my Alpine machine withmuslinstead ofglibc).