-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CodeAction to convert Tab characters to spaces #416
Add CodeAction to convert Tab characters to spaces #416
Conversation
Signed-off-by: Yevhen Vydolob <[email protected]>
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tried it out and everything was working for me! Just wondering if it also makes sense to have a code action with Convert all tabs to spaces
so we don't have to do it multiple times. I assume if someone has tabs in their yaml file they probably just have a setting enabled that keeps tabs as tabs instead of tabs to spaces
Signed-off-by: Yevhen Vydolob <[email protected]>
@JPinkney I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried with the newest changes and everything seemed to be working 👍
What does this PR do?
This PR adds various things:
Using tabs can lead to unpredictable results
diagnostic in to one, previously we report each tab character separatelyDemo:
Screen.Recording.2021-02-25.at.12.16.37.mov
Convert all tabs to spaces:
Screen.Recording.2021-02-25.at.17.08.27.mov
What issues does this PR fix or reference?
Fix: #244
Is it tested? How?
With new tests and manually, just create yaml file with tab's characters and see that
Using tabs can lead to unpredictable results
error has CodeActionConvert Tab to Spaces
and when it executed tabs replaced with spaces according to current editor settings.