-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new params to completion snippet #388
Merged
evidolob
merged 6 commits into
redhat-developer:master
from
p-spacek:feat/snippet-paramater-type-kind
Mar 4, 2021
Merged
feat: add new params to completion snippet #388
evidolob
merged 6 commits into
redhat-developer:master
from
p-spacek:feat/snippet-paramater-type-kind
Mar 4, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-spacek
requested review from
evidolob,
joshuawilson and
JPinkney
as code owners
January 11, 2021 20:07
evidolob
reviewed
Jan 12, 2021
p-spacek
commented
Jan 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
JPinkney
reviewed
Jan 18, 2021
JPinkney
approved these changes
Jan 26, 2021
@p-spacek Sorry for the delay, there are some tests fail. Could you fix them ASAP? I want to include this PR in to next release. |
@evidolob, I fixed the test. |
evidolob
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When object is type anyOf (array: null | string[]) some code completion doesn't work properly.
For example snippets on array it's not working very well.
Helps also in scenarios where yaml parser doesn't know that parent is array:
This new parameters can specify:
type
: type of snippet.symbolKind
: id of symbol that is displayed on completion panel.This feature probably doesn't solve the cause of the problem. But offers workaround.
What issues does this PR fix or reference?
Completion-Snippet: add parameters to defaultSnippets to specify the type and simbolKind
Is it tested? How?
added unit test