Rename all applicable Thenables to Promise #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh Pinkney <[email protected]>
Signed-off-by: Josh Pinkney <[email protected]>
joshuawilson
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Josh Pinkney [email protected]
What does this PR do?
This PR renames all Thenables to Promises and removes a few pieces of code that are never called. There is 1 lingering Thenable that I didn't get rid of in server.ts. The type returned for formatterRegistration is a Thenable (all promises are thenable but not all thenables are promises) so we can't convert it.
What issues does this PR fix or reference?
#138
Is it tested? How?
Tested to see that the yamlValidation contribution, json schema store schemas, setting a schema manually, and the custom contributor api all still work and then ran npm run test