Fix Partial Configuration Bug

[trajamsmith]

Small patch to fix #256.

When submitting partial settings objects to the language server using the onDidChangeConfiguration listener, the server was overwriting its default values with null values for every unspecified parameter.

[coveralls]

Coverage decreased (-0.2%) to 77.042% when pulling 068e925 on Trajamsmith:partial-configurations into 27522e8 on redhat-developer:master.

[trajamsmith]

These were overwritten if, e.g., yaml.validate.enabled was not specified in the configuration message.

[JPinkney]

Hmm after looking at it again I think there might be a small bug here:
ex for yamlShouldValidate

if settings.yaml.validate is undefined it will take the value of yamlShouldValidate ✔️
if settings.yaml.validate is true it will take that value ✔️

but
I think if settings.yaml.validate is false it will take the value of yamlShouldValidate if that's true, leading it to not change

I think we might have to do something like settings.yaml.validate ? settings.yaml.validate : yamlShouldValidate

That way of settings.yaml.validate is undefined it uses yamlShouldValidate
If settings.yaml.validate is defined and true it will use it
If settings.yaml.validate is defined and false it will use it

[trajamsmith]

You're absolutely right, I got the configuration object confused with that of another language server 😅 I think those ternary operators would still cause a problem though — if settings.yaml.validate is false (we want to set it to false) and yamlShouldValidate is true, then it will still be true.

What about just checking for the property:

if (settings.yaml.hasOwnProperty('validate') {
  yamlShouldValidate = settings.yaml.validate
}

[JPinkney]

if settings.yaml.validate is false (we want to set it to false) and yamlShouldValidate is true, then it will still be true.

Oh right 😅

I think just checking the property should suffice then!

In that case, if its undefined then nothing changes and if it is defined then it changes to whatever it was defined as

[trajamsmith]

Alright, it's a little more verbose but I feel like that should work 👍

[JPinkney]

Looks good from my side 👍

[trajamsmith]

Do you all have an idea of when you might next publish an NPM release? Would be great to have these configs available sooner than later, but it's not a big deal either way. Thanks for letting me help!

[JPinkney]

Hopefully in the next week or so, there's a decent amount of stuff that needs to be released now