Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing textEdit in CompletionItem when there is a newline #288

Open
apupier opened this issue Jul 22, 2020 · 1 comment
Open

Missing textEdit in CompletionItem when there is a newline #288

apupier opened this issue Jul 22, 2020 · 1 comment
Labels

Comments

@apupier
Copy link
Member

apupier commented Jul 22, 2020

test to reproduce:

it('Check text edit when there is a newline', done => {
                const schema = require(path.join(__dirname, './fixtures/testArrayMaxProperties.json'));
                languageService.addSchema(SCHEMA_ID, schema);
                const content = '- \n';
                const completion = parseSetup(content, content.length -1);
                completion.then(function (result) {
                    assert.equal(result.items.length, 3);
                    assert.deepEqual(result.items[0], createExpectedCompletion('prop1', 'prop1: $1', 0, 2, 0, 2, 10, 2, {
                        documentation: ''
                    }));
                    assert.deepEqual(result.items[1], createExpectedCompletion('prop2', 'prop2: $1', 0, 2, 0, 2, 10, 2, {
                        documentation: ''
                    }));
                    assert.deepEqual(result.items[2], createExpectedCompletion('prop3', 'prop3: $1', 0, 2, 0, 2, 10, 2, {
                        documentation: ''
                    }));
                }).then(done, done);
            });
apupier added a commit to apupier/yaml-language-server that referenced this issue Jul 22, 2020
the "textEdit" is not provided due to an existing bug on master
redhat-developer#288

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier
Copy link
Member Author

apupier commented Jul 22, 2020

would be nice to improve test related to this PR #280 when it will be fixed

@apupier apupier changed the title Missing textEdit when there is a newline Missing textEdit in CompletionItem when there is a newline Jul 22, 2020
@apupier apupier added the bug label Jul 23, 2020
@evidolob evidolob mentioned this issue Aug 10, 2020
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant