Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yaml.format.enable setting has opposed effect #158

Closed
remcohaszing opened this issue Feb 19, 2019 · 5 comments
Closed

yaml.format.enable setting has opposed effect #158

remcohaszing opened this issue Feb 19, 2019 · 5 comments
Assignees
Labels
Milestone

Comments

@remcohaszing
Copy link

I use prettier to format yaml code. I recently noticed the formatting was wrong. After some digging around, I found out this is because the vscode yaml extension also formats my code, taking precedence over prettier.

When I set "yaml.format.enable": true, the code is formatted using prettier. When I set "yaml.format.enable": false, or the setting is omitted, the code is formatted using the vscode yaml extension.

I believe a boolean should be flipped somewhere.

@JPinkney
Copy link
Contributor

Prettier is the the same formatter that this extension uses as well. I'll look into seeing where the flip would be.

@JPinkney
Copy link
Contributor

The fix will be available in the next release!

@devoto13
Copy link

devoto13 commented Mar 5, 2019

@JPinkney It looks more like this setting has no effect at all anymore, judging from this change it seems that the option is no longer recognized by the language server.

@JPinkney
Copy link
Contributor

JPinkney commented Mar 5, 2019

Its fixed as of redhat-developer/yaml-language-server#126 but I have no released yet

@JPinkney JPinkney added this to the 0.4.0 milestone Mar 12, 2019
@dogmatic69
Copy link

I've got 0.17.0 installed and seems like this does not work at all for formatting.
image

Am I missing a config, or a regression?

bleach31 pushed a commit to bleach31/vscode-yaml that referenced this issue Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants