Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan two levels of directories for activation indicators #2554

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

jdneo
Copy link
Collaborator

@jdneo jdneo commented Jul 12, 2022

fix #2280

Signed-off-by: Sheng Chen [email protected]

Copy link
Collaborator

@testforstephen testforstephen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdneo
Copy link
Collaborator Author

jdneo commented Jul 12, 2022

macos CI failed, looks like due to: microsoft/vscode-test#153. We need to update vscode-test to @vscode/test-electron

@jdneo
Copy link
Collaborator Author

jdneo commented Jul 13, 2022

Let's merge it first and see if we can receive any feedbacks from pre-release channel. If users are against this change strongly, we can revert it before the stable release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should support polyglot projects better
2 participants