Skip to content
This repository was archived by the owner on Jun 26, 2024. It is now read-only.

Conversation

@baijum
Copy link
Contributor

@baijum baijum commented Oct 10, 2022

Signed-off-by: Baiju Muthukadan [email protected]

Changes

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs
    included if any changes are user facing
  • Tests
    included if any functionality added or changed. For bugfixes please include tests that can catch regressions
  • All acceptance test scenarios included in the PR which verifies a bugfix or a requested feature reported by a non-member are tagged with @external-feedback tag.
  • Follows the commit message standard

@baijum baijum force-pushed the discovery-label branch 2 times, most recently from 452668f to 0f54d73 Compare October 12, 2022 08:12
@baijum
Copy link
Contributor Author

baijum commented Oct 17, 2022

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 17, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from baijum by writing /assign @baijum in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baijum baijum force-pushed the discovery-label branch 2 times, most recently from 085069c to 0cb35a0 Compare October 18, 2022 10:06
resource: deployments
"""
Then Service Binding is ready
And Kind RabbitmqCluster with apiVersion rabbitmq.com/v1beta1 is listed in bindable kinds
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have send a PR to add the label: rabbitmq/cluster-operator#1165
For now, I have removed this test.

@baijum
Copy link
Contributor Author

baijum commented Oct 18, 2022

/retest

@baijum
Copy link
Contributor Author

baijum commented Oct 18, 2022

/retest

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #1259 (a1847dd) into master (ba95a74) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head a1847dd differs from pull request most recent head b8f9662. Consider uploading reports for the commit b8f9662 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1259      +/-   ##
==========================================
+ Coverage   58.06%   58.09%   +0.02%     
==========================================
  Files          33       33              
  Lines        2797     2799       +2     
==========================================
+ Hits         1624     1626       +2     
  Misses       1018     1018              
  Partials      155      155              
Impacted Files Coverage Δ
pkg/reconcile/pipeline/context/service/service.go 77.69% <100.00%> (+0.34%) ⬆️
pkg/reconcile/pipeline/handler/collect/impl.go 80.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba95a74...b8f9662. Read the comment docs.

@pmacik
Copy link
Contributor

pmacik commented Oct 19, 2022

There is one HIGH security vulnerability recently identified (CVE-2022-32149), but is fixed already in master - please rebase to fix that.

@baijum
Copy link
Contributor Author

baijum commented Oct 19, 2022

/hold

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 19, 2022

@baijum: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.9-acceptance b8f9662 link true /test 4.9-acceptance

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@baijum baijum closed this Oct 20, 2022
@baijum baijum deleted the discovery-label branch November 11, 2022 04:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants