-
Notifications
You must be signed in to change notification settings - Fork 89
Use label to discover Provisioned Service #1259
Conversation
452668f to
0f54d73
Compare
|
/retest |
0f54d73 to
301a76c
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
085069c to
0cb35a0
Compare
| resource: deployments | ||
| """ | ||
| Then Service Binding is ready | ||
| And Kind RabbitmqCluster with apiVersion rabbitmq.com/v1beta1 is listed in bindable kinds |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have send a PR to add the label: rabbitmq/cluster-operator#1165
For now, I have removed this test.
|
/retest |
0cb35a0 to
3ec8147
Compare
|
/retest |
3ec8147 to
a1847dd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #1259 +/- ##
==========================================
+ Coverage 58.06% 58.09% +0.02%
==========================================
Files 33 33
Lines 2797 2799 +2
==========================================
+ Hits 1624 1626 +2
Misses 1018 1018
Partials 155 155
Continue to review full report at Codecov.
|
|
There is one HIGH security vulnerability recently identified (CVE-2022-32149), but is fixed already in master - please rebase to fix that. |
a1847dd to
8d51fde
Compare
Signed-off-by: Baiju Muthukadan <[email protected]>
8d51fde to
b8f9662
Compare
|
/hold |
|
@baijum: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed-off-by: Baiju Muthukadan [email protected]
Changes
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
included if any changes are user facing
included if any functionality added or changed. For bugfixes please include tests that can catch regressions
@external-feedbacktag.