Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support building and running tests with podman #276

Merged
merged 13 commits into from
Jun 13, 2019

Conversation

tmds
Copy link
Member

@tmds tmds commented May 23, 2019

This is building and tests pass on Fedora with podman from Fedora repos and s2i from https://github.com/openshift/source-to-image/releases.

Some tests are not passing with podman and are being skipped. I need to look into this further.

Based on this, I've created some issues for podman vs docker differences: containers/podman#3184, containers/podman#3191

Fixes #274

@tmds tmds requested review from omajid and aslicerh May 23, 2019 13:39
2.1/build/test/testcommon Outdated Show resolved Hide resolved
@tmds
Copy link
Member Author

tmds commented Jun 5, 2019

🎉 This ran successful on f30 ci for building the centos and ubi images.

On f29 and rhel8 it doesn't due to bugs/missing features in the podman stack.
I hope in the near future this will also 'just work' on rhel8 when the packages gets updated.

You can run this rootless, but then you have to update your inotify and open fd limits. Otherwise the test will fail in strange ways. Running as sudo is the simplest to work around those limits.

@aslicerh @omajid can you review the proposed changes?

@aslicerh
Copy link
Member

aslicerh commented Jun 5, 2019

Woo! Thanks for all this. I'll look it over later today, but I just wanted to address something real quick:

I hope in the near future this will also 'just work' on rhel8 when the packages gets updated.

podman is expected be updated in 8.1 to a version that supports 'podman cp', so I expect that it would.

@tmds
Copy link
Member Author

tmds commented Jun 5, 2019

podman is expected be updated in 8.1 to a version that supports 'podman cp', so I expect that it would.

Great! The build on rhel8 got pretty far, until it hit the missing podman cp in test_devmode.

@aslicerh
Copy link
Member

aslicerh commented Jun 5, 2019

Great! The build on rhel8 got pretty far, until it hit the missing podman cp in test_devmode.

Locally I've replaced the podman cp with mounting a directory on the host and manipulating the files that way and it has passed the devmode and split_build tests, just to add.

@tmds
Copy link
Member Author

tmds commented Jun 6, 2019

Locally I've replaced the podman cp with mounting a directory on the host and manipulating the files that way and it has passed the devmode and split_build tests, just to add.

If you share the code I can put it in. Unless you don't mind waiting for rhel8.1?
My main interest is this works on f30 because that is what I use for development.

@tmds
Copy link
Member Author

tmds commented Jun 11, 2019

If there are no further review comments, I will copy over the changes to the 2.2 version and then merge this after a successful run on f30 CI.

@aslicerh
Copy link
Member

This all looks good to me. Thanks for all the hard work!

Also, I like your solution to the libpod issue much better than the terrible and hacky one I had for my own tests!

@tmds
Copy link
Member Author

tmds commented Jun 11, 2019

Thanks Andrew, I'm sure your workarounds weren't too bad :)

@tmds
Copy link
Member Author

tmds commented Jun 13, 2019

Our f30 CI vm is broken. I ran the tests locally and they passed.

@tmds tmds merged commit 015eedb into redhat-developer:master Jun 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable building and testing on podman-based system
3 participants