Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #7005

Merged
merged 1 commit into from
Sep 22, 2023
Merged

Replace github.com/ghodss/yaml with sigs.k8s.io/yaml #7005

merged 1 commit into from
Sep 22, 2023

Conversation

Juneezee
Copy link
Contributor

What type of PR is this:

/area refactoring

What does this PR do / why we need it:

The github.com/ghodss/yaml package is no longer actively maintained. There are numerous inquiries about the project's status on its issue tracker: https://github.com/ghodss/yaml/issues. sigs.k8s.io/yaml is a permanent fork of github.com/ghodss/yaml, which is actively maintained by Kubernetes SIG and widely used in K8s projects.

Since sigs.k8s.io/yaml was already a dependency before this pull request was made, we can remove 1 extra dependency by replacing github.com/ghodss/yaml with sigs.k8s.io/yaml.

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the area/refactoring Issues or PRs related to code refactoring label Jul 28, 2023
@netlify
Copy link

netlify bot commented Jul 28, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 2f5396c
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/650c79c4445a5f000879799e

@openshift-ci
Copy link

openshift-ci bot commented Jul 28, 2023

Hi @Juneezee. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. label Jul 28, 2023
@openshift-ci openshift-ci bot requested review from feloy and rm3l July 28, 2023 12:40
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

NoCluster Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

Unit Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

Validate Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

OpenShift Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

Windows Tests (OCP) on commit 4476f37 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 28, 2023 •
edited
Loading

Kubernetes Tests on commit 4476f37 finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Jul 28, 2023

/hold

I remember we have chosen to use this specific library in this specific place because the k8s.io one was not working the same way.

I need to check if this is still true with the current versions

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Jul 28, 2023
@Juneezee
Replace github.com/ghodss/yaml with sigs.k8s.io/yaml
2f5396c 
At the time of making this commit, the package `github.com/ghodss/yaml`
is no longer actively maintained.

`sigs.k8s.io/yaml` is a permanent fork of `ghodss/yaml` and is actively
maintained by Kubernetes SIG.

Signed-off-by: Eng Zer Jun <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Sep 21, 2023

Kubernetes Docs Tests on commit 0f828ec finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Sep 22, 2023

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. Required by Prow. label Sep 22, 2023
@feloy
Copy link
Contributor

feloy commented Sep 22, 2023

/lgtm

Thanks @Juneezee for this change.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 22, 2023
@feloy
Copy link
Contributor

feloy commented Sep 22, 2023

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. Required by Prow. labels Sep 22, 2023
@rm3l rm3l added this to the v3.15.0 🚀 milestone Sep 22, 2023
@rm3l rm3l added the area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs label Sep 22, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0959b56 into redhat-developer:main Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy Awaiting requested review from feloy

@rm3l rm3l Awaiting requested review from rm3l

Assignees

@feloy feloy

Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs area/refactoring Issues or PRs related to code refactoring lgtm Indicates that a PR is ready to be merged. Required by Prow. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Milestone
v3.15.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@Juneezee @feloy @rm3l @openshift-merge-robot