Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dev UI Cypress E2E tests #6967

Merged

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jul 13, 2023

What type of PR is this:
/area testing

What does this PR do / why we need it:
In preparation for the work on #6902, this PR is an attempt to fix Cypress E2E tests for the Dev UI.
It uses the api-server command introduced in #6943 and runs it against the UI folder itself #inception #dogfooding

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

rm3l added 7 commits July 13, 2023 09:42
…ures

This should make it easier to understand and investigate.
The default timeout used to cause certain flakiness at times.
…press runs

It outputs actions, intercepted requests, console messages and errors directly to stdout in a convenient format.

[1] https://github.com/archfz/cypress-terminal-report
…il we get successful responses

In some cases, clicking too quickly led to inconsistent behavior, where for example the Containers tab would not be up-to-date yet
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 13, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 13, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit e4d6f8b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64afbc6df2f272000870317b

@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jul 13, 2023
@rm3l rm3l added this to the v3.13.0 🚀 milestone Jul 13, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 13, 2023

Kubernetes Docs Tests on commit bc16851 finished successfully.
View logs: TXT HTML

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rm3l rm3l changed the title [WIP] Fix Dev UI Cypress E2E tests Fix Dev UI Cypress E2E tests Jul 13, 2023
@rm3l rm3l marked this pull request as ready for review July 13, 2023 09:45
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 13, 2023
@openshift-ci openshift-ci bot requested review from feloy and valaparthvi July 13, 2023 09:45
@rm3l rm3l removed the request for review from valaparthvi July 13, 2023 09:49
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 15, 2023
@openshift-merge-robot openshift-merge-robot merged commit c0af267 into redhat-developer:main Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants