Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display information about the running API Server and web UI in odo describe component output #6964

Merged
merged 7 commits into from
Jul 18, 2023
Merged

Display information about the running API Server and web UI in odo describe component output #6964

merged 7 commits into from
Jul 18, 2023
+274 −40

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jul 12, 2023 •
edited
Loading

What type of PR is this:
/kind feature
/area dev
/area describe-component

What does this PR do / why we need it:

Which issue(s) this PR fixes:
Fixes #6942

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Sorry, something went wrong.

rm3l added 4 commits July 12, 2023 10:11
@rm3l
refactor: Set the experimental mode env var in a single place for the…
3e7a5ee 
… '--api-server' related tests
@rm3l
Add integration tests highlighting the expectations
ad4437a
@rm3l
Make the state client return the API server ports per platform
a5d2c62 
'odo dev' might be running on both cluster and podman,
so we might end up with several API servers.
@rm3l
Make 'odo describe component' return information about the API Server…
52b6c0f 
… and web UI

This is viewable only when running 'odo describe component'
with the experimental mode enabled.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 12, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jul 12, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 562151e
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64b677ce510b2600097808bd

@openshift-ci openshift-ci bot added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/dev Issues or PRs related to `odo dev` area/describe-component Issues or PRs related to `odo describe component` labels Jul 12, 2023
@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

NoCluster Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

Unit Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

Validate Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

Kubernetes Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

OpenShift Tests on commit f253a5b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

Windows Tests (OCP) on commit f253a5b finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jul 12, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 9fd65cd finished successfully.
View logs: TXT HTML

@rm3l rm3l changed the title [WIP] Display information about the running API Server and web UI in odo describe component output Display information about the running API Server and web UI in odo describe component output Jul 12, 2023
@rm3l rm3l marked this pull request as ready for review July 12, 2023 15:33
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jul 12, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and rnapoles-rh July 12, 2023 15:34
@rm3l rm3l closed this Jul 12, 2023
@rm3l rm3l reopened this Jul 12, 2023
@rm3l rm3l closed this Jul 12, 2023
@rm3l rm3l reopened this Jul 12, 2023
feloy
feloy reviewed Jul 17, 2023
View reviewed changes
@rm3l rm3l requested a review from feloy July 17, 2023 13:15
@rm3l @feloy
Simplify logic for 'describe#filterByPlatform', as suggested in review
562151e 
Co-authored-by: Philippe Martin <phmartin@redhat.com>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

feloy
feloy approved these changes Jul 18, 2023
View reviewed changes
Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jul 18, 2023
@rm3l
Copy link
Member Author

rm3l commented Jul 18, 2023 

  [odo]   __
  [odo]  /  \__     Developing using the "iavbsw" Devfile
  [odo]  \__/  \    Namespace: cmd-dev-api-server-test65wbk
  [odo]  /  \__/    odo version: v3.12.0
  [odo]  \__/
  [odo] 
  [odo] - Running on the cluster in Dev mode
  [odo] I0718 06:45:22.814799    5144 content.go:48] converted devfile YAML to JSON
  [odo] I0718 06:45:22.815058    5144 apiVersion.go:60] devfile schemaVersion: '2.2.0'
  [odo] I0718 06:45:22.815094    5144 helper.go:56] devfile apiVersion '2.2.0' is supported
  [odo] I0718 06:45:22.818457    5144 schema.go:61] validated devfile schema
  [odo] I0718 06:45:22.818831    5144 writer.go:55] devfile yaml created at: 'devfile.yaml'
  [odo] I0718 06:45:22.843619    5144 starterserver.go:73] API Server started at localhost:20000/api/v1
  [odo] I0718 06:45:22.843619    5144 kubedev.go:86] Creating new adapter
  [odo] I0718 06:45:22.843619    5144 kubedev.go:94] Creating inner-loop resources for the component
  [odo] I0718 06:45:22.843619    5144 watch.go:101] starting WatchAndPush, path: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272, component: iavbsw, ignores [.git .odo .odo\odo-file-index.json]
  [odo] I0718 06:45:22.844229    5144 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
  [odo] I0718 06:45:22.848321    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272
  [odo] I0718 06:45:22.850060    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272\.odo
  [odo] I0718 06:45:22.852097    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272\test
  [odo] I0718 06:45:22.853426    5144 implem.go:114] The path for preference file is C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\944688627\preference.yaml
  [odo] I0718 06:45:22.853765    5144 segment.go:264] Checking telemetry enable status
  [odo] I0718 06:45:22.853765    5144 segment.go:282] Sending telemetry disabled by env variable
  [odo] Cleaning resources, please wait
  [odo]  X  error watching deployment: context canceled
  [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4378/tests/helper/helper_run.go:50 @ 07/18/23 06:45:32.627

Ports conflict issue on Windows (#6939)

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

 [odo]   __
 [odo]  /  \__     Developing using the "iavbsw" Devfile
 [odo]  \__/  \    Namespace: cmd-dev-api-server-test65wbk
 [odo]  /  \__/    odo version: v3.12.0
 [odo]  \__/
 [odo] 
 [odo] - Running on the cluster in Dev mode
 [odo] I0718 06:45:22.814799    5144 content.go:48] converted devfile YAML to JSON
 [odo] I0718 06:45:22.815058    5144 apiVersion.go:60] devfile schemaVersion: '2.2.0'
 [odo] I0718 06:45:22.815094    5144 helper.go:56] devfile apiVersion '2.2.0' is supported
 [odo] I0718 06:45:22.818457    5144 schema.go:61] validated devfile schema
 [odo] I0718 06:45:22.818831    5144 writer.go:55] devfile yaml created at: 'devfile.yaml'
 [odo] I0718 06:45:22.843619    5144 starterserver.go:73] API Server started at localhost:20000/api/v1
 [odo] I0718 06:45:22.843619    5144 kubedev.go:86] Creating new adapter
 [odo] I0718 06:45:22.843619    5144 kubedev.go:94] Creating inner-loop resources for the component
 [odo] I0718 06:45:22.843619    5144 watch.go:101] starting WatchAndPush, path: C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272, component: iavbsw, ignores [.git .odo .odo\odo-file-index.json]
 [odo] I0718 06:45:22.844229    5144 starterserver.go:93] Stopping the API server; encountered error: listen tcp :20000: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
 [odo] I0718 06:45:22.848321    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272
 [odo] I0718 06:45:22.850060    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272\.odo
 [odo] I0718 06:45:22.852097    5144 file_watcher.go:130] adding watch on path C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\3603146272\test
 [odo] I0718 06:45:22.853426    5144 implem.go:114] The path for preference file is C:\Users\Administrator.ANSIBLE-TEST-VS\AppData\Local\Temp\944688627\preference.yaml
 [odo] I0718 06:45:22.853765    5144 segment.go:264] Checking telemetry enable status
 [odo] I0718 06:45:22.853765    5144 segment.go:282] Sending telemetry disabled by env variable
 [odo] Cleaning resources, please wait
 [odo]  X  error watching deployment: context canceled
 [FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/4378/tests/helper/helper_run.go:50 @ 07/18/23 06:45:32.627

Ports conflict issue on Windows (#6939)

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 6e72595 into redhat-developer:main Jul 18, 2023
@rm3l rm3l deleted the 6942-odo-describe-component-should-display-the-running-api-server-port branch July 18, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy

Assignees

@feloy feloy

Labels
area/describe-component Issues or PRs related to `odo describe component` area/dev Issues or PRs related to `odo dev` kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

odo describe component should display the running API Server
3 participants
@rm3l @feloy @openshift-merge-robot