-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement API endpoints #6915
Merged
openshift-merge-robot
merged 15 commits into
redhat-developer:main
from
feloy:feature-6302/api-endpoints-impl-main
Jun 26, 2023
+513
−271
Merged
Implement API endpoints #6915
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
952ecbd
Pass odo context to api server
feloy f4c44af
Get /instance
feloy ef96c2a
DELETE /instance implementation
feloy 191c782
Move describe logic to pkg/component/describe
feloy 1ef6d22
Get /component implementation
feloy 23f1d58
POST /component/command implementation
feloy 6315727
Fix example by replacing action with name
feloy 4c23ffb
Fix integration test
feloy 961a358
Integration tests
feloy 13bc66f
Add comment for PushWatcher
feloy 70bdea2
Test DELETE /instance without --no-watch
feloy 877a685
Apply suggestions from code review
feloy a8bd866
Return an error if not ready for push
feloy e031198
Fix windows tests
feloy cbb362d
Fix tests for Windows
feloy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if the response body in case of error should not be serialized as a real JSON string too. Currently, I get a simple string, which does not respect the response content type returned in the response headers:
I'd expect something like below. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we will need to complete the openapi spec, to define a return code in case of error, a,d to point to the correct
GeneralError
instead of using the default. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that makes sense.