Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement HTTP Server based on OpenAPI spec #6835

Merged
merged 7 commits into from
Jun 19, 2023

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6301

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 23, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 23, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label May 23, 2023
@netlify
Copy link

netlify bot commented May 23, 2023

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 00844bb
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64903938847d0800082d9244
😎 Deploy Preview https://deploy-preview-6835--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

NoCluster Tests on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

OpenShift Unauthenticated Tests on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Validate Tests on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Unit Tests on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Kubernetes Tests on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Kubernetes Docs Tests on commit 4f46fe9 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

Windows Tests (OCP) on commit 23bfe04 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 23, 2023

OpenShift Tests on commit 23bfe04 finished with errors.
View logs: TXT HTML

@valaparthvi valaparthvi marked this pull request as ready for review May 26, 2023 17:51
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 26, 2023
@valaparthvi valaparthvi changed the title Implement HTTP Server based on OpenAPI spec WIP: Implement HTTP Server based on OpenAPI spec May 26, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 26, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy May 26, 2023 17:51
@valaparthvi valaparthvi force-pushed the apiserver branch 4 times, most recently from 68dcf53 to 2d4e389 Compare May 29, 2023 12:14
@valaparthvi valaparthvi requested review from rm3l and removed request for anandrkskd May 29, 2023 13:46
@valaparthvi valaparthvi changed the title WIP: Implement HTTP Server based on OpenAPI spec Implement HTTP Server based on OpenAPI spec May 29, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label May 29, 2023
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. Required by Prow. label Jun 15, 2023
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
pkg/apiserver-impl/starterserver.go Outdated Show resolved Hide resolved
pkg/apiserver-impl/starterserver.go Outdated Show resolved Hide resolved
pkg/state/types.go Outdated Show resolved Hide resolved
@valaparthvi valaparthvi reopened this Jun 19, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 8 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@feloy
Copy link
Contributor

feloy commented Jun 19, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 3 Failures:
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 3 Failures:
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 /go/odo_1/tests/helper/helper_run.go:54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jun 19, 2023

/override ODO-PODMAN-TEST

[FAILED] [10.535 seconds]
2023-06-19T14:07:24.0836727Z odo dev command tests odo dev on podman with a devfile bound to fail [It] should fail with an error [podman]

Passes locally

[FAILED] [42.023 seconds]
2023-06-19T14:03:39.8397608Z odo dev command tests when running odo dev and composite command are nested - with metadata.name [It] should execute all commands in composite commmand [podman]

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ODO-PODMAN-TEST

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/odo-ocp4.14-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ODO-PODMAN-TEST

[FAILED] [10.535 seconds]
2023-06-19T14:07:24.0836727Z odo dev command tests odo dev on podman with a devfile bound to fail [It] should fail with an error [podman]

Passes locally

[FAILED] [42.023 seconds]
2023-06-19T14:03:39.8397608Z odo dev command tests when running odo dev and composite command are nested - with metadata.name [It] should execute all commands in composite commmand [podman]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jun 19, 2023

/override odo-podman-test

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • odo-podman-test

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/odo-ocp4.14-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override odo-podman-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jun 19, 2023

/override "odo-podman-test / ODO-PODMAN-TEST"

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • odo-podman-test / ODO-PODMAN-TEST

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/odo-ocp4.14-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "odo-podman-test / ODO-PODMAN-TEST"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Jun 19, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 3 Failures:
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
  /go/odo_1/tests/helper/helper_run.go:54
  [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
  /go/odo_1/tests/helper/helper_run.go:54

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 3 Failures:
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when killing odo dev and running odo delete component --wait should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when a component is bootstrapped when odo dev is executed and Ephemeral is set to false [BeforeEach] when stopping odo dev normally should have deleted all resources before returning
 /go/odo_1/tests/helper/helper_run.go:54
 [FAIL] odo dev command tests when running odo dev with devfile containing volume-component - without metadata.name [BeforeEach] should successfully use the volume components in container components
 /go/odo_1/tests/helper/helper_run.go:54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor Author

/override ODO-PODMAN-TEST

Details

  [FAILED] Expected
      <string>:   __
       /  \__     Developing using the "aovvpm" Devfile
       \__/  \    Platform: podman
       /  \__/    odo version: v3.11.0
       \__/
      
      ↪ Running on podman in Dev mode
       •  Deploying pod  ...
       ✗  Deploying pod [2s]
      Error occurred on Push - exit status 125: 
      Complete Podman output:
      Trying to pull registry.access.redhat.com/ubi8/nose-12:1-36...
      �����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
      
      
      ↪ Dev mode
       Status:
       Watching for changes in the current directory /tmp/3872295102
      
       Keyboard Commands:
      [Ctrl+c] - Exit and delete resources from podman
           [p] - Manually apply local changes to the application on podman
      
  to contain substring
      <string>: Repo not found

[FAILED] Unexpected error:
      <*errors.errorString | 0xc0016be120>: {
          s: "exit status 255: ",
      }
      exit status 255: 
  occurred

Summarizing 2 Failures:
  [FAIL] odo dev command tests when running odo dev and composite command are nested - with metadata.name [It] should execute all commands in composite commmand [podman]
  /home/runner/work/odo/odo/tests/helper/component_podman.go:67
  [FAIL] odo dev command tests odo dev on podman with a devfile bound to fail [It] should fail with an error [podman]
  /home/runner/work/odo/odo/tests/helper/helper_generic.go:79

@openshift-ci
Copy link

openshift-ci bot commented Jun 19, 2023

@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ODO-PODMAN-TEST

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/odo-ocp4.14-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override ODO-PODMAN-TEST

Details

 [FAILED] Expected
     <string>:   __
      /  \__     Developing using the "aovvpm" Devfile
      \__/  \    Platform: podman
      /  \__/    odo version: v3.11.0
      \__/
     
     ↪ Running on podman in Dev mode
      •  Deploying pod  ...
      ✗  Deploying pod [2s]
     Error occurred on Push - exit status 125: 
     Complete Podman output:
     Trying to pull registry.access.redhat.com/ubi8/nose-12:1-36...
     �����������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������������
     
     
     ↪ Dev mode
      Status:
      Watching for changes in the current directory /tmp/3872295102
     
      Keyboard Commands:
     [Ctrl+c] - Exit and delete resources from podman
          [p] - Manually apply local changes to the application on podman
     
 to contain substring
     <string>: Repo not found

[FAILED] Unexpected error:
     <*errors.errorString | 0xc0016be120>: {
         s: "exit status 255: ",
     }
     exit status 255: 
 occurred

Summarizing 2 Failures:
 [FAIL] odo dev command tests when running odo dev and composite command are nested - with metadata.name [It] should execute all commands in composite commmand [podman]
 /home/runner/work/odo/odo/tests/helper/component_podman.go:67
 [FAIL] odo dev command tests odo dev on podman with a devfile bound to fail [It] should fail with an error [podman]
 /home/runner/work/odo/odo/tests/helper/helper_generic.go:79

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 19, 2023
@openshift-merge-robot openshift-merge-robot merged commit 0b012f3 into redhat-developer:main Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement HTTP Server based on OpenAPI spec
4 participants