Set vcs-uri annotation on podman #6746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
the
do-not-merge/work-in-progress
feloy
force-pushed
the
feature-6493/vcs-uri-annotation
branch
from
19920d2 to
fd9f6e0
Compare
feloy
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
Podman v3 cannot get annotations from a running pod, so it is not possible to test it on GitHub ACtion with Podman v3 for now. |
rm3l
reviewed
Apr 19, 2023
tests/integration/cmd_dev_test.go
Outdated
| @@ -2373,7 +2373,7 @@ CMD ["npm", "start"] | |||
| devfileCmpName := "nodejs" | |||
| BeforeEach(func() { | |||
| if podman { | |||
| Skip("Not implemented yet on Podman - see https://github.com/redhat-developer/odo/issues/6493") | |||
| Skip("Getting annotations is not available with Podman v3") | |||
There was a problem hiding this comment.
Would it be possible to be more specific (as we are able to determine the actual version of Podman) and skip the test only if it is < v4? So that we can still have this tested with Podman v4..
I am perfectly okay if you think it is not worth the effort for now.
It would be great to look into how we could have tests on both Podman v3 and v4, but that's the scope of #6583
rm3l
requested changes
Apr 19, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
rm3l
approved these changes
Apr 19, 2023
openshift-ci
bot
added
the
lgtm
|
/override OpenShift-Integration-tests/OpenShift-Integration-tests |
|
@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override windows-integration-test/Windows-test |
|
@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this:
/kind feature
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6493
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: