Fix problem when odo deploy processes do not terminate #6716
Conversation
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
kind/bug
feloy
force-pushed
the
tests/odo-deploy-no-stop
branch
from
81f9c57 to
00d2060
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -117,6 +117,7 @@ func (cw *CmdWrapper) ShouldRun() *CmdWrapper { | |||
| func (cw *CmdWrapper) Should(f func(session *gexec.Session)) { | |||
| cw.Runner() | |||
| f(cw.session) | |||
| cw.session.Wait() | |||
There was a problem hiding this comment.
This seems to fix the problem, logs point so.
Ran 436 of 788 Specs in 1079.759 seconds
SUCCESS! -- 436 Passed | 0 Failed | 0 Pending | 352 Skipped
Ginkgo ran 1 suite in 19m5.388476487s
Test Suite PassedBut I don't understand why this missing piece created a problem in the first place.
I also noticed that if you check this run on IBM cloud, the duration for Job run was Duration1 hour, 57 minutes, 19 seconds, but the test run duration was Duration23 minutes, 40 seconds, is that normal?
There was a problem hiding this comment.
But I don't understand why this missing piece created a problem in the first place.
The tests were terminating before the processes odo deploy were terminated. Ginkgo probably has problems handling children processes remaining after the tests finish.
I also noticed that if you check this run on IBM cloud, the duration for Job run was Duration1 hour, 57 minutes, 19 seconds, but the test run duration was Duration23 minutes, 40 seconds, is that normal?
The job waited 1h34 before to start.
|
/lgtm |
openshift-ci
bot
added
the
lgtm
|
/override windows-integration-test/Windows-test [oc] ""Unable to connect to the server: dial tcp 158.177.79.34:31700: connectex: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond.
[FAILED] in [BeforeEach] - C:/Users/Administrator.ANSIBLE-TEST-VS/3617/tests/helper/helper_oc.go:34 @ 04/04/23 12:20:15.12
Deleting project: cmd-logs-test194pap
Summarizing 1 Failure:
[FAIL] odo logs command tests when component is created and odo logs is executed when running in Deploy mode [BeforeEach] should successfully show logs of the running component
C:/Users/Administrator.ANSIBLE-TEST-VS/3617/tests/helper/helper_oc.go:34 |
|
@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind bug
/area testing
What does this PR do / why we need it:
Which issue(s) this PR fixes:
Fixes #6715
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: