Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add DEVFILE_REGISTRY env var for periodic tests #6709

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Add DEVFILE_REGISTRY env var for periodic tests #6709

merged 2 commits into from
Apr 3, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Apr 3, 2023

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6702

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Apr 3, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 2eae2c1
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/642ae410405d6100088c064b
😎 Deploy Preview https://deploy-preview-6709--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2023

@feloy: The label(s) kind/tests cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6702

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy feloy requested review from anandrkskd and rm3l April 3, 2023 11:34
@openshift-ci openshift-ci bot requested review from ritudes and rnapoles-rh April 3, 2023 11:34
@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit cf90e07 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

NoCluster Tests on commit cf90e07 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

Unit Tests on commit cf90e07 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

Validate Tests on commit cf90e07 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

Windows Tests (OCP) on commit cf90e07 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023 •
edited
Loading

OpenShift Tests on commit cf90e07 finished with errors.
View logs: TXT HTML

valaparthvi
valaparthvi suggested changes Apr 3, 2023
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.
There's one more change: You'll also need to fix scripts/openshiftci-Nightly-SBO-tests.sh.

@feloy feloy requested a review from valaparthvi April 3, 2023 14:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Apr 3, 2023

Kubernetes Docs Tests on commit 252a77d finished with errors.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 3, 2023
@rm3l
Copy link
Member

rm3l commented Apr 3, 2023 

[FAILED] Expected
      <*url.Error | 0xc00087f920>: {
          Op: "Post",
          URL: "http://127.0.0.1:53061/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3594/tests/e2escenarios/e2e_test.go:306 @ 04/03/23 10:00:56.756

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3594/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.093 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2023

@rm3l: Overrode contexts on behalf of rm3l: windows-integration-test/Windows-test

In response to this:

[FAILED] Expected
     <*url.Error | 0xc00087f920>: {
         Op: "Post",
         URL: "http://127.0.0.1:53061/api/newuser",
         Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3594/tests/e2escenarios/e2e_test.go:306 @ 04/03/23 10:00:56.756

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3594/tests/e2escenarios/e2e_test.go:306

Ran 7 of 7 Specs in 208.093 seconds
FAIL! -- 6 Passed | 1 Failed | 0 Pending | 0 Skipped

Flaky E2E test (#6582)

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Apr 3, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated tests

@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2023

@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests, OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override OpenShift-Integration-tests/OpenShift-Integration-tests
Unrelated tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Apr 3, 2023
@rm3l rm3l added this to the v3.9.0 🚀 milestone Apr 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit f0bf9ee into redhat-developer:main Apr 3, 2023
valaparthvi added a commit to valaparthvi/odo that referenced this pull request Apr 6, 2023
@valaparthvi
Revert "Add DEVFILE_REGISTRY env var for periodic tests (redhat-devel…
dc7b4d5 
…oper#6709)"

This reverts commit f0bf9ee.
@valaparthvi valaparthvi mentioned this pull request Apr 6, 2023
Merged
3 tasks
openshift-merge-robot pushed a commit that referenced this pull request Apr 12, 2023
@valaparthvi
Revert "Add DEVFILE_REGISTRY env var for periodic tests (#6709)" (#6725)
4317255 
* Revert "Add DEVFILE_REGISTRY env var for periodic tests (#6709)"

This reverts commit f0bf9ee.

* Use IBM Devfile registry for InterOP testing

Signed-off-by: Parthvi Vala <[email protected]>

---------

Signed-off-by: Parthvi Vala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@ritudes ritudes Awaiting requested review from ritudes

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

@valaparthvi valaparthvi

Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.9.0 🚀
Development

Successfully merging this pull request may close these issues.

Use In-cluster Devfile registries for integration tests
4 participants
@feloy @rm3l @valaparthvi @openshift-merge-robot