Doc automation:Command Reference: odo create namespace #6703

ritudes · 2023-03-31T10:28:22Z

What type of PR is this:

/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6675
PR acceptance criteria:

Unit test
Integration test
Documentation

How to test changes / Special notes to the reviewer:

openshift-ci · 2023-03-31T10:28:27Z

@ritudes: The label(s) kind/tests cannot be applied, because the repository doesn't have them.

In response to this:

What type of PR is this:
/kind tests
/area/documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6675
PR acceptance criteria:

Unit test

Integration test

Documentation

How to test changes / Special notes to the reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

netlify · 2023-03-31T10:28:29Z

✅ Deploy Preview for odo-docusaurus-preview ready!

Name	Link
🔨 Latest commit	`fccaea5`
🔍 Latest deploy log	https://app.netlify.com/sites/odo-docusaurus-preview/deploys/642ebfa3f96a770008a1a030
😎 Deploy Preview	https://deploy-preview-6703--odo-docusaurus-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

odo-robot · 2023-03-31T10:34:46Z

Windows Tests (OCP) on commit 14d4357 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-31T10:35:48Z

NoCluster Tests on commit 14d4357 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-31T10:36:34Z

OpenShift Unauthenticated Tests on commit 898426d finished with errors.
View logs: TXT HTML

odo-robot · 2023-03-31T10:36:39Z

Unit Tests on commit 14d4357 finished successfully.
View logs: TXT HTML

odo-robot · 2023-03-31T10:43:08Z

Validate Tests on commit 14d4357 finished successfully.
View logs: TXT HTML

valaparthvi

This looks good! Thank you for working on this :)
Apart from the changes I have suggested, there is one more change I'd like i.e. Restore the yarn.lock file

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go

docs/website/docs/command-reference/docs-mdx/create-namespace/create_namespace.mdx

docs/website/docs/command-reference/docs-mdx/create-namespace/create_project.mdx

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go

odo-robot · 2023-03-31T12:33:23Z

OpenShift Tests on commit 14d4357 finished with errors.
View logs: TXT HTML

odo-robot · 2023-03-31T13:03:22Z

Kubernetes Tests on commit 14d4357 finished successfully.
View logs: TXT HTML

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go

odo-robot · 2023-04-06T10:20:09Z

Kubernetes Docs Tests on commit c2d850f finished successfully.
View logs: TXT HTML

valaparthvi · 2023-04-06T10:39:32Z

@ritudes Can you rebase your branch on top of the latest main branch? That should fix the doc test failure.

  [FAILED] registry_list_output.mdx
  Expected
      <string>:   strings.Join({
        	... // 101 identical bytes
        	"                               VERSIONS\nnodejs-react  StagingReg",
        	"istry         React is a free and open-source front-en...  2.0.2",
      + 	", 2.1.0",
        	"\nnodejs-react  DefaultDevfileRegistry  React is a free and open-",
        	"source front-en...  2.0.2\n```\n",
        }, "")
      
  to be empty
Summarizing 1 Failure:
  [FAIL] doc command reference odo init Non Interactive Mode fetching devfile from a registry when setting up the registry [It] Fetch Devfile from any registry of the list [nocluster]
  /go/odo_1/tests/documentation/command-reference/doc_command_reference_init_test.go:189

Philippe has already fixed this failure in #6710.

…create_namespace.mdx Co-authored-by: Parthvi Vala <[email protected]>

…create_project.mdx Co-authored-by: Parthvi Vala <[email protected]>

…eatenamespace_test.go Co-authored-by: Parthvi Vala <[email protected]>

Signed-off-by: Ritu Deshmukh <[email protected]>

valaparthvi · 2023-04-10T05:21:59Z

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

  [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
  Expected
      <string>:   (
        	"""
        	... // 10 identical lines
        	âœ“  Added storage m2 to component
        	âš   Pod is Pending
      - 	âœ“  Pod is Running
        	âœ“  Syncing files into the container [1s]
        	âœ“  Building your application in container (command: build) [1s]
        	... // 9 identical lines
        	[Ctrl+c] - Exit and delete resources from the cluster
        	[p] - Manually apply local changes to the application on the cluster
      + 	âœ“  Pod is Running
        	```
        	"""
        )
      
  to be empty
  In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 04/06/23 13:23:11.307
------------------------------

Summarizing 1 Failure:
  [FAIL] User guides: Quickstart test Java quickstart guide [It] s

openshift-ci · 2023-04-10T05:22:03Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

 [FAILED] user-guides/quickstart/docs-mdx/java/java_odo_dev_output.mdx
 Expected
     <string>:   (
       	"""
       	... // 10 identical lines
       	âœ“  Added storage m2 to component
       	âš   Pod is Pending
     - 	âœ“  Pod is Running
       	âœ“  Syncing files into the container [1s]
       	âœ“  Building your application in container (command: build) [1s]
       	... // 9 identical lines
       	[Ctrl+c] - Exit and delete resources from the cluster
       	[p] - Manually apply local changes to the application on the cluster
     + 	âœ“  Pod is Running
       	```
       	"""
       )
     
 to be empty
 In [It] at: /go/odo_1/tests/documentation/user-guides/doc_user_guides_quickstart_test.go:256 @ 04/06/23 13:23:11.307
------------------------------

Summarizing 1 Failure:
 [FAIL] User guides: Quickstart test Java quickstart guide [It] s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sonarqubecloud · 2023-04-10T06:18:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

valaparthvi · 2023-04-10T06:43:19Z

/override windows-integration-test/Windows-test

  [FAILED] Expected
      <*url.Error | 0xc00057e720>: {
          Op: "Post",
          URL: "http://127.0.0.1:55919/api/newuser",
          Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
      }
  to be nil
  In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3654/tests/e2escenarios/e2e_test.go:306 @ 04/10/23 00:48:11.831

  There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
  [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
  C:/Users/Administrator.ANSIBLE-TEST-VS/3654/tests/e2escenarios/e2e_test.go:306

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 1 Failure:
  [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
  /go/odo_1/tests/helper/helper_dev.go:207

Overriding the failures because they are not related to the PR.

openshift-ci · 2023-04-10T06:43:26Z

@valaparthvi: Overrode contexts on behalf of valaparthvi: OpenShift-Integration-tests/OpenShift-Integration-tests, windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

 [FAILED] Expected
     <*url.Error | 0xc00057e720>: {
         Op: "Post",
         URL: "http://127.0.0.1:55919/api/newuser",
         Err: <*errors.errorString | 0xc00008a130>{s: "EOF"},
     }
 to be nil
 In [It] at: C:/Users/Administrator.ANSIBLE-TEST-VS/3654/tests/e2escenarios/e2e_test.go:306 @ 04/10/23 00:48:11.831

 There were additional failures detected.  To view them in detail run ginkgo -vv
------------------------------

Summarizing 1 Failure:
 [FAIL] E2E Test starting with non-empty Directory add Binding [It] should verify developer workflow of using binding as env in innerloop
 C:/Users/Administrator.ANSIBLE-TEST-VS/3654/tests/e2escenarios/e2e_test.go:306

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Summarizing 1 Failure:
 [FAIL] odo dev command tests when Starting a PostgreSQL service when creating local files and dir and running odo dev - without metadata.name [AfterEach] when deleting local files and dir and waiting for sync should not list deleted dir and file in container
 /go/odo_1/tests/helper/helper_dev.go:207

Overriding the failures because they are not related to the PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci bot requested review from rm3l and rnapoles-rh March 31, 2023 10:28

ritudes requested review from valaparthvi and removed request for rnapoles-rh March 31, 2023 10:29

valaparthvi suggested changes Mar 31, 2023

View reviewed changes

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go Outdated Show resolved Hide resolved

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go Outdated Show resolved Hide resolved

openshift-ci bot assigned valaparthvi Mar 31, 2023

valaparthvi suggested changes Mar 31, 2023

View reviewed changes

ritudes force-pushed the issue/#6675 branch from 0f10bf4 to 3539355 Compare March 31, 2023 11:34

ritudes requested a review from valaparthvi April 6, 2023 08:45

valaparthvi reviewed Apr 6, 2023

View reviewed changes

tests/documentation/command-reference/doc_command_reference_createnamespace_test.go Show resolved Hide resolved

ritudes and others added 7 commits April 6, 2023 18:17

doc automation files for create namespace command

799f3c7

test file for of create namespace cmd

0137159

Update docs/website/docs/command-reference/docs-mdx/create-namespace/…

4ad17a7

…create_namespace.mdx Co-authored-by: Parthvi Vala <[email protected]>

Update docs/website/docs/command-reference/docs-mdx/create-namespace/…

63e8479

…create_project.mdx Co-authored-by: Parthvi Vala <[email protected]>

Update tests/documentation/command-reference/doc_command_reference_cr…

8cf8292

…eatenamespace_test.go Co-authored-by: Parthvi Vala <[email protected]>

Update doc_command_reference_createnamespace_test.go

c322b59

Adding changes to test file

fccaea5

Signed-off-by: Ritu Deshmukh <[email protected]>

ritudes force-pushed the issue/#6675 branch from 42d3705 to fccaea5 Compare April 6, 2023 12:48

valaparthvi approved these changes Apr 10, 2023

View reviewed changes

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Apr 10, 2023

valaparthvi closed this Apr 10, 2023

valaparthvi reopened this Apr 10, 2023

ritudes closed this Apr 10, 2023

ritudes reopened this Apr 10, 2023

openshift-merge-robot merged commit 5ec9907 into redhat-developer:main Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doc automation:Command Reference: odo create namespace #6703

Doc automation:Command Reference: odo create namespace #6703

ritudes commented Mar 31, 2023 •

edited

Loading

openshift-ci bot commented Mar 31, 2023

netlify bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

valaparthvi left a comment

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Apr 6, 2023 •

edited

Loading

valaparthvi commented Apr 6, 2023

valaparthvi commented Apr 10, 2023

openshift-ci bot commented Apr 10, 2023

sonarqubecloud bot commented Apr 10, 2023

valaparthvi commented Apr 10, 2023

openshift-ci bot commented Apr 10, 2023

Doc automation:Command Reference: odo create namespace #6703

Doc automation:Command Reference: odo create namespace #6703

Conversation

ritudes commented Mar 31, 2023 • edited Loading

openshift-ci bot commented Mar 31, 2023

netlify bot commented Mar 31, 2023 • edited Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Mar 31, 2023 • edited Loading

valaparthvi left a comment

Choose a reason for hiding this comment

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Mar 31, 2023 • edited Loading

odo-robot bot commented Apr 6, 2023 • edited Loading

valaparthvi commented Apr 6, 2023

valaparthvi commented Apr 10, 2023

openshift-ci bot commented Apr 10, 2023

sonarqubecloud bot commented Apr 10, 2023

valaparthvi commented Apr 10, 2023

openshift-ci bot commented Apr 10, 2023

ritudes commented Mar 31, 2023 •

edited

Loading

netlify bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Mar 31, 2023 •

edited

Loading

odo-robot bot commented Apr 6, 2023 •

edited

Loading