Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UX issue when exec command fails to run as part of a deploy command #6673

Merged
merged 1 commit into from
Mar 23, 2023
Merged

Fix UX issue when exec command fails to run as part of a deploy command #6673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pkg/deploy/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,9 @@ func (o *deployHandler) Execute(command v1alpha2.Command) error {
// Wait for the command to complete execution
_, err = o.kubeClient.WaitForJobToComplete(createdJob)
done <- struct{}{}

spinner.End(err == nil)

if err != nil {
err = fmt.Errorf("failed to execute (command: %s)", command.Id)
// Print the job logs if the job failed
Expand All @@ -203,8 +206,6 @@ func (o *deployHandler) Execute(command v1alpha2.Command) error {
_ = util.DisplayLog(false, jobLogs, log.GetStderr(), o.componentName, 100)
}

spinner.End(err == nil)

return err
}

Expand Down