Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make port-forwarding work on Podman with apps listening on the loopback interface, via a new --forward-localhost flag #6629

Merged
merged 15 commits into from
Mar 6, 2023
Merged

Make port-forwarding work on Podman with apps listening on the loopback interface, via a new --forward-localhost flag #6629

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0ac62cc
Embed platform.Client interface in platform-specific interfaces
rm3l Feb 10, 2023
7419d14
Verify interface compliance of PodmanCli at compile time
rm3l Feb 10, 2023
25499f9
Move K8s-specific implementation of port-forwarding to a dedicated pa…
rm3l Feb 10, 2023
9817a9b
Remove GetPortsToForward method from the portForward.Client interface
rm3l Feb 10, 2023
872156f
Monitor and send appropriate status events after starting a remote co…
rm3l Feb 10, 2023
9f07573
Implement port-forwarding logic on Podman
rm3l Feb 10, 2023
2802ed6
Update portForward.Client interface methods
rm3l Feb 10, 2023
dc5fec0
Add helper sidecar container to the Pod Spec generated on Podman
rm3l Feb 10, 2023
ea088f6
Inject the right portForward client depending on the platform
rm3l Feb 10, 2023
c7e4b0e
Delegate port-forwarding on Podman to the appropriate client
rm3l Feb 10, 2023
2c49fa8
Implement --forward-localhost on Podman
rm3l Feb 28, 2023
3829bcf
Add unit and integration test cases
rm3l Mar 1, 2023
4e0d071
Cover more debug-related test cases on Podman
rm3l Feb 10, 2023
ef3238a
Expose the endpoint protocol so as to instruct socat to listen and fo…
rm3l Mar 2, 2023
7b384d3
Fix sub-deps of EXEC and PORT_FORWARD, as suggested in review
rm3l Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add unit and integration test cases
@rm3l
rm3l committed Mar 2, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
commit 3829bcf7d4af1a6bdf8d3d7dbf36bc3718a44a61
Loading