Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe non-odo component #6615

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Feb 22, 2023

What type of PR is this:

/kind bug

What does this PR do / why we need it:

odo describe component --name <non-odo-component> displays information

Which issue(s) this PR fixes:

Fixes #6584

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 22, 2023
@netlify
Copy link

netlify bot commented Feb 22, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d4f9a3b
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63f63df70004b3000819eb13

@openshift-ci openshift-ci bot requested review from anandrkskd and kadel February 22, 2023 08:44
@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

OpenShift Unauthenticated Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

NoCluster Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

Unit Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6584/describe-non-odo-component branch from 54d0f4b to 04562ff Compare February 22, 2023 08:59
@feloy feloy requested review from valaparthvi and rm3l and removed request for kadel and anandrkskd February 22, 2023 09:02
@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

Validate Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

Windows Tests (OCP) on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

Kubernetes Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

OpenShift Tests on commit c1761f3 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 22, 2023

Kubernetes Docs Tests on commit 6b9c6a9 finished successfully.
View logs: TXT HTML

@feloy feloy changed the title [wip] Describe non-odo component Describe non-odo component Feb 22, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 22, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 27, 2023
@rm3l
Copy link
Member

rm3l commented Feb 27, 2023

/test v4.12-images

@openshift-merge-robot openshift-merge-robot merged commit 79504e3 into redhat-developer:main Feb 27, 2023
@feloy feloy mentioned this pull request Mar 6, 2023
3 tasks
anandrkskd pushed a commit to anandrkskd/odo that referenced this pull request Mar 7, 2023
* Do not add odo/app on selector for named describe

* Display route

* Add integration tests

* Fix unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odo describe component fails when trying to get info about "non-odo" component
3 participants