-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger the IBM Cloud Image Workflow on PRs as well #6587
Trigger the IBM Cloud Image Workflow on PRs as well #6587
Conversation
This allows to test that the image can be built successfully on PRs as well. Pushing the image is run only upon a push on the 'main' branch.
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
Kudos, SonarCloud Quality Gate passed! |
/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests Not applicable |
@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you help me understand what this image is used for? I read the Dockerfile and and odo-robot code but it did not make much sense to me. |
We use this image for our test on IBM Cloud, if you check stage configuration you will see we are using a custom docker image. |
Yes, as written by Anand, that's what this image is used for. IBM Cloud will spin up a container off of this image (set in the stage configuration) that will run the test script (also set in the stage configuration). |
What type of PR is this:
/area testing
What does this PR do / why we need it:
For some context, while working on #6586, I wanted to make sure that updating the Go version in the Dockerfile will not break the image (this happened already in the past - see #6166 (comment)).
I checked manually but thought it would be nice to have our Workflow check that instead.
So this PR allows us to test that the image can be built successfully on PRs as well.
Pushing the image to the registry is run only upon a push on the
main
branch.Which issue(s) this PR fixes:
—
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer:
An example of workflow run on this PR: https://github.com/redhat-developer/odo/actions/runs/4135154988/jobs/7147225272