Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger the IBM Cloud Image Workflow on PRs as well #6587

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Feb 9, 2023

What type of PR is this:
/area testing

What does this PR do / why we need it:

For some context, while working on #6586, I wanted to make sure that updating the Go version in the Dockerfile will not break the image (this happened already in the past - see #6166 (comment)).
I checked manually but thought it would be nice to have our Workflow check that instead.
So this PR allows us to test that the image can be built successfully on PRs as well.

Pushing the image to the registry is run only upon a push on the main branch.

Which issue(s) this PR fixes:

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:
An example of workflow run on this PR: https://github.com/redhat-developer/odo/actions/runs/4135154988/jobs/7147225272

This allows to test that the image can be built successfully on PRs as well.
Pushing the image is run only upon a push on the 'main' branch.
@openshift-ci openshift-ci bot added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Feb 9, 2023
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit de7e061
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63e5005874d4c40008dba3bd

@openshift-ci openshift-ci bot requested review from feloy and kadel February 9, 2023 14:17
@rm3l rm3l requested review from anandrkskd and removed request for kadel February 9, 2023 14:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

OpenShift Unauthenticated Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l requested review from valaparthvi and removed request for feloy and valaparthvi February 9, 2023 14:23
@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

Unit Tests on commit finished successfully.
View logs: TXT HTML

@rm3l rm3l mentioned this pull request Feb 9, 2023
3 tasks
@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

Kubernetes Docs Tests on commit ad77fe7 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Feb 9, 2023

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@rm3l
Copy link
Member Author

rm3l commented Feb 9, 2023

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Not applicable

@openshift-ci
Copy link

openshift-ci bot commented Feb 9, 2023

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests

Not applicable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l rm3l added this to the v3.7.0 🚀 milestone Feb 9, 2023
@valaparthvi
Copy link
Contributor

valaparthvi commented Feb 13, 2023

Can you help me understand what this image is used for? I read the Dockerfile and and odo-robot code but it did not make much sense to me.

@anandrkskd
Copy link
Contributor

anandrkskd commented Feb 13, 2023

Can you help me understand what this image is used for? I read the Dockerfile and and odo-robot code but it did not make much sense to me.

We use this image for our test on IBM Cloud, if you check stage configuration you will see we are using a custom docker image.
This image contains everything we need to build odo, execute tests against it and upload logs to IBM Cloud bucket

@rm3l
Copy link
Member Author

rm3l commented Feb 13, 2023

Can you help me understand what this image is used for? I read the Dockerfile and and odo-robot code but it did not make much sense to me.

We use this image for our test on IBM Cloud, if you check stage configuration you will see we are using a custom docker image. This image contains everything we need to build odo, execute tests against it and upload logs to IBM Cloud bucket

Yes, as written by Anand, that's what this image is used for. IBM Cloud will spin up a container off of this image (set in the stage configuration) that will run the test script (also set in the stage configuration).
This image is currently built and pushed only upon a Git push on main, but I wanted to make sure it was also built (locally on the runner) for PRs as well, to make sure it builds at least.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 13, 2023
@openshift-merge-robot openshift-merge-robot merged commit 99b0acd into redhat-developer:main Feb 13, 2023
@rm3l rm3l deleted the trigger_build_ibm_image_workflow_on_pr_but_push_only_on_main branch February 13, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants