Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for OpenShift Devfile components #6548

Merged
merged 17 commits into from
Feb 3, 2023
Merged

Add support for OpenShift Devfile components #6548

merged 17 commits into from
Feb 3, 2023

Conversation

rm3l
Copy link
Member

@rm3l rm3l commented Jan 30, 2023 •
edited
Loading

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #5704

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jan 30, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@netlify
Copy link

netlify bot commented Jan 30, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 9bfd383
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63dce2e72def44000815008f

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

NoCluster Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

Unit Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

Kubernetes Docs Tests on commit bd0d2ef finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

Windows Tests (OCP) on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

Validate Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

OpenShift Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 30, 2023 •
edited
Loading

Kubernetes Tests on commit 1660b41 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the 5704-support-openshift-devfile-components-the-same-way-as-kubernetes-components branch from a6a3929 to d14ae0b Compare January 31, 2023 10:27
@valaparthvi
Copy link
Contributor

IBM K8s failure is related to because there was an abrupt logout from the cluster.

While the following tests failed on OC:

Summarizing 3 Failures:
  [FAIL] odo dev command tests 1. devfile contains composite apply command when odo dev is running [It] should execute the composite apply commands successfully
  /go/odo_1/tests/integration/cmd_dev_test.go:1684
  [FAIL] odo dev debug command tests when a composite apply command is used as debug command [It] should execute the composite apply commands successfully
  /go/odo_1/tests/helper/helper_oc.go:34
  [FAIL] odo dev command tests checking if odo dev matches local Devfile K8s resources and remote resources when odo dev is executed to run a devfile containing a k8s resource with apply command [BeforeEach] should have deleted the old resource and created the new resource
  /go/odo_1/tests/integration/cmd_dev_test.go:562

  Expected
      <[]uint8 | len:124, cap:124>: [78, 65, 77, 69, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 82, 69, 65, 68, 89, 32, 32, 32, 85, 80, 45, 84, 79, 45, 68, 65, 84, 69, 32, 32, 32, 65, 86, 65, 73, 76, 65, 66, 76, 69, 32, 32, 32, 65, 71, 69, 10, 109, 121, 45, 111, 112, 101, 110, 115, 104, 105, 102, 116, 45, 99, 111, 109, 112, 111, 110, 101, 110, 116, 32, 32, 32, 48, 47, 49, 32, 32, 32, 32, 32, 49, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 48, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 32, 55, 49, 115, 10]
  not to contain substring
      <string>: my-openshift-component

@rm3l rm3l linked an issue Feb 1, 2023 that may be closed by this pull request
Support openshift Devfile components (the same way as kubernetes components) #5704
Closed
rm3l and others added 12 commits February 2, 2023 15:54
@rm3l @anandrkskd @feloy
Add integration test case
b4362ae 
Co-authored-by: Anand Kumar Singh <[email protected]>
Co-authored-by: Philippe Martin <[email protected]>
@feloy
Add ApplyOpenShift method to handler
edc0639
@feloy
Test openhift component with odo dev
477f4cc
@valaparthvi @feloy
Rename GetKubernetesComponentsToPush to GetK8sAndOcComponentsToPush a…
a365cfa 
…nd modify if to obtain both k8s and oc components

Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi @feloy
Fix unit test failures with delete_test
9b8cf92 
Signed-off-by: Parthvi Vala <[email protected]>
@anandrkskd @feloy
update ListClusterResourcesToDeleteFromDevfile to fetch openshift com…
11b2423 
…ponent,Add ListOpenShiftComponents

Signed-off-by: anandrkskd <[email protected]>
@anandrkskd @feloy
fix testcase 'should have deleted the old resource and created the ne…
18b5631 
…w resource' and add helper function ReplaceStrings

Signed-off-by: anandrkskd <[email protected]>
@anandrkskd @feloy
fix debug test to check openshift component
2d947c4 
Signed-off-by: anandrkskd <[email protected]>
@feloy
Update GetBindingsFromDevfile to include openshift components
4287dd0
@feloy
Update offline tests
2a0a301
@feloy
Add openshift component to devfiles
5715983
@feloy
Update tests
863e806
@feloy feloy force-pushed the 5704-support-openshift-devfile-components-the-same-way-as-kubernetes-components branch from ddae24c to 863e806 Compare February 2, 2023 14:54
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rm3l rm3l marked this pull request as ready for review February 3, 2023 11:15
@rm3l rm3l changed the title [WIP] Add support for OpenShift Devfile components Add support for OpenShift Devfile components Feb 3, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Feb 3, 2023
@openshift-ci openshift-ci bot requested review from anandrkskd and feloy February 3, 2023 11:16
@rm3l rm3l added kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation area/component area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. area/binding Issues or PRs related to `odo add/delete binding *` commands or Service Binding Operator area/deploy Issues or PRs specific to the `odo deploy` command area/dev Issues or PRs related to `odo dev` labels Feb 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Feb 3, 2023
@openshift-merge-robot openshift-merge-robot merged commit eeda644 into redhat-developer:main Feb 3, 2023
@rm3l rm3l deleted the 5704-support-openshift-devfile-components-the-same-way-as-kubernetes-components branch February 3, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feloy feloy feloy approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

Assignees

@feloy feloy

Labels
area/binding Issues or PRs related to `odo add/delete binding *` commands or Service Binding Operator area/deploy Issues or PRs specific to the `odo deploy` command area/dev Issues or PRs related to `odo dev` area/devfile-spec Issues or PRs related to the Devfile specification and how odo handles and interprets it. kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support openshift Devfile components (the same way as kubernetes components)
5 participants
@rm3l @valaparthvi @feloy @openshift-merge-robot @anandrkskd