Fix potential issues with E2E tests #6543
Conversation
…ws checking (or not) the remote command execution
…equests to the local forwarded port Otherwise, sending a request too early causes "connection refused" errors, which causes port-forwarding to be restarted (with new local ports because "odo dev" is running with "--random-ports"). As a first start, here we are making sure that the application port is available in the container, prior to sending requests to the local forwarded port. This should reduce the likeliness of port-forwarding restarts. In the future, we might want to make the test detect the new local ports and use those instead. We could even make sure to make "odo dev" reuse the previous random ports it had, provided they are available again.
This allows checking the application running in the container.
…he Devfile redhat-developer#6101 has been fixed.
openshift-ci
bot
added
the
do-not-merge/work-in-progress
✅ Deploy Preview for odo-docusaurus-preview canceled.
|
openshift-ci
bot
added
kind/tests
area/testing
|
All relevant tests passed on all platforms. Let's trigger them one more time. |
rm3l
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
…at allows checking (or not) the remote command execution
…nding requests to the local forwarded port
…suggested in review Co-authored-by: Philippe Martin <[email protected]>
openshift-ci
bot
added
the
lgtm
|
Kudos, SonarCloud Quality Gate passed!
|
|
/override Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests |
|
@feloy: Overrode contexts on behalf of feloy: Kubernetes-Integration-Tests/Kubernetes-Docs-Integration-Tests, windows-integration-test/Windows-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/v4.11-integration-e2e |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/unit-and-validate-test |
|
@feloy: Overrode contexts on behalf of feloy: ci/prow/unit-and-validate-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this:
/kind tests
/area testing
What does this PR do / why we need it:
This is an attempt to fix the recurring issues we have been seeing with E2E tests.
In a nutshell, it waits for the application to be actually running in the container before sending a request to the local port created by odo.
Otherwise, sending a request to the local port too early sometimes causes the port forwarding to be automatically restarted (with new random ports because we are running
odo devwith--random-ports) (#6013)Which issue(s) this PR fixes:
Fixes #6463
PR acceptance criteria:
Unit test
Integration test
Documentation
How to test changes / Special notes to the reviewer: