Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log error when podman client cannot be initialized #6538

Merged
merged 11 commits into from
Feb 3, 2023
+68 −23
Merged

Log error when podman client cannot be initialized #6538

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7849f20
Log error when podman client cannot be initialized
valaparthvi Jan 25, 2023
523f728
Return error if platform is podman
valaparthvi Jan 26, 2023
d76ba48
Refactor errors related to cluster/podman inaccessible
valaparthvi Jan 31, 2023
650513a
Fix integration test
valaparthvi Jan 31, 2023
d4998f6
fix validation failure
valaparthvi Jan 31, 2023
c1ee117
rm3l's review
valaparthvi Feb 1, 2023
0b30499
Attempt at fixing CI failures
valaparthvi Feb 1, 2023
4d057f7
Log error when unable to find podman client in NewPodmanCli
valaparthvi Feb 1, 2023
cff630c
Update pkg/podman/podman.go
valaparthvi Feb 3, 2023
5d246ff
Update pkg/podman/errors.go
valaparthvi Feb 3, 2023
3b22e20
Fix integration test
valaparthvi Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix validation failure
@valaparthvi
valaparthvi committed Jan 31, 2023
commit d4998f61acea8d5634d45725e0c405819fbc6946
2 changes: 1 addition & 1 deletion pkg/kclient/errors.go
View file
Original file line number Diff line number Diff line change
@@ -28,5 +28,5 @@ func NewNoConnectionError() NoConnectionError {

func (e NoConnectionError) Error() string {
// could also be "cluster is non accessible"
return fmt.Sprintf("unable to access the cluster")
return "unable to access the cluster"
}