Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop containers after Podman tests #6535

Merged
merged 4 commits into from
Jan 25, 2023
Merged

Stop containers after Podman tests #6535

merged 4 commits into from
Jan 25, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Jan 25, 2023

What type of PR is this:

/kind tests

What does this PR do / why we need it:

Stop containers, to make the ginkgo process terminate

Which issue(s) this PR fixes:

Fixes #6532

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Jan 25, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit d8b6d23
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63d1187c1993900008e7cf22

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

OpenShift Tests on commit 81e2e67 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

NoCluster Tests on commit 81e2e67 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Unit Tests on commit 81e2e67 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Validate Tests on commit 81e2e67 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Kubernetes Tests on commit 81e2e67 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 25, 2023 •
edited
Loading

Windows Tests (OCP) on commit 81e2e67 finished with errors.
View logs: TXT HTML

@feloy feloy force-pushed the tests/stop-podman-containers branch from 9a0c390 to cd6aba5 Compare January 25, 2023 10:09
@feloy feloy requested a review from rm3l January 25, 2023 10:09
@rm3l rm3l mentioned this pull request Jan 25, 2023
Closed
3 tasks
@feloy feloy requested a review from rm3l January 25, 2023 11:55
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 25, 2023
@rm3l
Copy link
Member

rm3l commented Jan 25, 2023

/override ci/prow/v4.11-integration-e2e
/override windows-integration-test/Windows-test

Flaky E2E test (reported in #6463)

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e, windows-integration-test/Windows-test

In response to this:

/override ci/prow/v4.11-integration-e2e
/override windows-integration-test/Windows-test

Flaky E2E test (reported in #6463)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Jan 25, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky issue with E2E tests (reported in #6463).

@openshift-ci
Copy link

openshift-ci bot commented Jan 25, 2023

@rm3l: Overrode contexts on behalf of rm3l: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky issue with E2E tests (reported in #6463).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 9ebf766 into redhat-developer:main Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@anandrkskd anandrkskd Awaiting requested review from anandrkskd

@valaparthvi valaparthvi Awaiting requested review from valaparthvi

Assignees

@rm3l rm3l

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Podman tests not finishing
3 participants
@feloy @rm3l @openshift-merge-robot