Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore and show warning when handling Kubernetes components on Podman #6471

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala pvala@redhat.com

What type of PR is this:
/kind feature

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #6299

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

  1. odo init --devfile go --starter go-starter --name my-go-app
  2. Use the following Devfile:
devfile.yaml
commands:
- exec:
    commandLine: go build main.go
    component: runtime
    env:
    - name: GOPATH
      value: ${PROJECT_SOURCE}/.go
    - name: GOCACHE
      value: ${PROJECT_SOURCE}/.cache
    group:
      isDefault: true
      kind: build
    workingDir: ${PROJECT_SOURCE}
  id: build
- exec:
    commandLine: ./main
    component: runtime
    group:
      isDefault: true
      kind: run
    workingDir: ${PROJECT_SOURCE}
  id: run

components:
- container:
    args:
    - tail
    - -f
    - /dev/null
    endpoints:
    - name: http-go
      targetPort: 8080
    image: registry.access.redhat.com/ubi9/go-toolset:latest
    memoryLimit: 1024Mi
    mountSources: true
  name: runtime
# This will create a Deployment in order to run your container image across
# the cluster.
- name: outerloop-deployment
  kubernetes:
    inlined: |
      kind: Deployment
      apiVersion: apps/v1
      metadata:
        name: {{RESOURCE_NAME}}
      spec:
        replicas: 1
        selector:
          matchLabels:
            app: {{RESOURCE_NAME}}
        template:
          metadata:
            labels:
              app: {{RESOURCE_NAME}}
          spec:
            containers:
              - name: {{RESOURCE_NAME}}
                image: registry.access.redhat.com/ubi9/go-toolset:latest
                ports:
                  - name: http
                    containerPort: {{CONTAINER_PORT}}
                    protocol: TCP
                resources:
                  limits:
                    memory: "1024Mi"
                    cpu: "500m"
metadata:
  description: Go is an open source programming language that makes it easy to build
    simple, reliable, and efficient software.
  displayName: Go Runtime
  icon: https://raw.githubusercontent.com/devfile-samples/devfile-stack-icons/main/golang.svg
  language: Go
  name: my-go-app
  projectType: Go
  provider: Red Hat
  tags:
  - Go
  version: 1.0.2
# Deploy "kind" ID's use schema 2.2.0+
schemaVersion: 2.2.0
starterProjects:
- description: A Go project with a simple HTTP server
  git:
    checkoutFrom:
      revision: main
    remotes:
      origin: https://github.com/devfile-samples/devfile-stack-go.git
  name: go-starter
# Add the following variables code anywhere in devfile.yaml
# This MUST be a container registry you are able to access
variables:
  # CONTAINER_IMAGE: quay.io/MYUSERNAME/go-odo-example
  RESOURCE_NAME: my-go-app
  CONTAINER_PORT: "8080"
  DOMAIN_NAME: go.example.com
  1. ODO_EXPERIMENTAL_MODE=true odo dev --platform=podman

Sorry, something went wrong.

@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit b115d37
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63c6653a96bb690008044d1e

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Jan 6, 2023
@openshift-ci openshift-ci bot requested review from kadel and rm3l January 6, 2023 08:53
@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

OpenShift Tests on commit 8b2c004 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

NoCluster Tests on commit 8b2c004 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

Unit Tests on commit 8b2c004 finished successfully.
View logs: TXT HTML

@valaparthvi valaparthvi force-pushed the 6299_warning_k8s_on_podman branch from 3d9bf2d to 6d455e6 Compare January 6, 2023 09:03
@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

Validate Tests on commit 8b2c004 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

Kubernetes Tests on commit 8b2c004 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Jan 6, 2023

Windows Tests (OCP) on commit 8b2c004 finished with errors.
View logs: TXT HTML

@valaparthvi valaparthvi requested a review from rm3l January 6, 2023 18:28
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
…rces referenced by apply command and add test for it

Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi force-pushed the 6299_warning_k8s_on_podman branch from 217eb93 to c1e451b Compare January 12, 2023 16:52
@valaparthvi valaparthvi changed the title Ignore and show warning when handling Kubernetes components on Podman WIP: Ignore and show warning when handling Kubernetes components on Podman Jan 13, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 13, 2023
@valaparthvi valaparthvi force-pushed the 6299_warning_k8s_on_podman branch from 28a591c to 812cb12 Compare January 13, 2023 11:30
@valaparthvi valaparthvi changed the title WIP: Ignore and show warning when handling Kubernetes components on Podman Ignore and show warning when handling Kubernetes components on Podman Jan 13, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jan 13, 2023
… attempt at fixing CI failures

Signed-off-by: Parthvi Vala <pvala@redhat.com>
@valaparthvi valaparthvi force-pushed the 6299_warning_k8s_on_podman branch from 812cb12 to 04e0156 Compare January 13, 2023 13:50
@valaparthvi valaparthvi requested a review from rm3l January 13, 2023 16:26
Signed-off-by: Parthvi Vala <pvala@redhat.com>
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Just a small suggestion to update a function doc.

Co-authored-by: Armel Soro <armel@rm3l.org>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jan 17, 2023
@valaparthvi valaparthvi reopened this Jan 17, 2023
@rm3l rm3l closed this Jan 17, 2023
@rm3l rm3l reopened this Jan 17, 2023
@rm3l rm3l closed this Jan 17, 2023
@rm3l rm3l reopened this Jan 17, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@valaparthvi
Copy link
Contributor Author

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Jan 18, 2023

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 53a2a23 into redhat-developer:main Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[odo on Podman] Ignore and show warning when handling Kubernetes components
3 participants