Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flake odo add binding in interactive doest show namespace recently created #6391

Merged
merged 1 commit into from
Dec 9, 2022
Merged

Flake odo add binding in interactive doest show namespace recently created #6391

merged 1 commit into from
Dec 9, 2022

Conversation

anandrkskd
Copy link
Contributor

What type of PR is this:

/kind tests

What does this PR do / why we need it:
This PR fixes test Flake of odo interactive mode

  • [It] should error out if service is not found in the namespace selected

Which issue(s) this PR fixes:

Fixes #6390

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Dec 8, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 30fd769
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63918cbe6c4b1000092938ec

@openshift-ci openshift-ci bot requested review from feloy and valaparthvi December 8, 2022 06:54
@anandrkskd anandrkskd changed the title Flake test: odo add binding in interactive does't show namespace recently created Flake odo add binding in interactive doest show namespace recently created Dec 8, 2022
@anandrkskd anandrkskd closed this Dec 8, 2022
@anandrkskd anandrkskd reopened this Dec 8, 2022
valaparthvi
valaparthvi reviewed Dec 8, 2022
View reviewed changes
tests/helper/helper_kubectl.go Outdated
@@ -162,7 +162,6 @@ func (kubectl KubectlRunner) createAndSetRandNamespaceProject(projectName string
Cmd("kubectl", "config", "set-context", "--current", "--namespace", projectName).ShouldPass()
session := Cmd("kubectl", "get", "namespaces").ShouldPass().Out()
Expect(session).To(ContainSubstring(projectName))
kubectl.addConfigMapForCleanup(projectName) // add configmap for cleanup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove this? Didn't we add this to ensure necessary cleanup?

Copy link
Contributor Author

@anandrkskd anandrkskd Dec 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are no longer using this function for cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad we are using it.

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

NoCluster Tests on commit 26d20c7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Unit Tests on commit 26d20c7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Validate Tests on commit 26d20c7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Windows Tests (OCP) on commit 26d20c7 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

Kubernetes Tests on commit 26d20c7 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Dec 8, 2022 •
edited
Loading

OpenShift Tests on commit 26d20c7 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Dec 9, 2022
@feloy feloy closed this Dec 9, 2022
@feloy feloy reopened this Dec 9, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@feloy
Copy link
Contributor

feloy commented Dec 9, 2022

/override windows-integration-test/Windows-test
Unrelated e2e flaky tst

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test
Unrelated e2e flaky tst

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor

feloy commented Dec 9, 2022

/override ci/prow/v4.11-integration-e2e

odo devfile registry command tests [nocluster]
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_devfile_registry_test.go:12
  [It] Should list detailed information regarding nodejs
  /go/src/github.com/redhat-developer/odo/tests/integration/cmd_devfile_registry_test.go:45


"message": "Get \"https://registry.stage.devfile.io/index\": dial tcp: lookup registry.stage.devfile.io on 172.30.0.10:53: read udp 10.131.0.4:38471-\u003e172.30.0.10:53: read: connection refused"

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

odo devfile registry command tests [nocluster]
/go/src/github.com/redhat-developer/odo/tests/integration/cmd_devfile_registry_test.go:12
 [It] Should list detailed information regarding nodejs
 /go/src/github.com/redhat-developer/odo/tests/integration/cmd_devfile_registry_test.go:45


"message": "Get \"https://registry.stage.devfile.io/index\": dial tcp: lookup registry.stage.devfile.io on 172.30.0.10:53: read udp 10.131.0.4:38471-\u003e172.30.0.10:53: read: connection refused"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rm3l
Copy link
Member

rm3l commented Dec 9, 2022

/override ci/prow/v4.11-integration-e2e

    [oc] from server for: "/go/src/github.com/redhat-developer/odo/tests/examples/manifests/bindablekind-instance.yaml": Get "https://api.ci-op-f8432z34-c362a.origin-ci-int-aws.dev.rhcloud.com:6443/apis/postgresql.k8s.enterprisedb.io/v1/namespaces/cmd-add-binding-test260ita/clusters/cluster-sample": dial tcp: lookup api.ci-op-f8432z34-c362a.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: read udp 10.131.12.211:52212->172.30.0.10:53: i/o timeout

@openshift-ci
Copy link

openshift-ci bot commented Dec 9, 2022

@rm3l: Overrode contexts on behalf of rm3l: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e

   [oc] from server for: "/go/src/github.com/redhat-developer/odo/tests/examples/manifests/bindablekind-instance.yaml": Get "https://api.ci-op-f8432z34-c362a.origin-ci-int-aws.dev.rhcloud.com:6443/apis/postgresql.k8s.enterprisedb.io/v1/namespaces/cmd-add-binding-test260ita/clusters/cluster-sample": dial tcp: lookup api.ci-op-f8432z34-c362a.origin-ci-int-aws.dev.rhcloud.com on 172.30.0.10:53: read udp 10.131.12.211:52212->172.30.0.10:53: i/o timeout

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 3032ee3 into redhat-developer:main Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valaparthvi valaparthvi valaparthvi left review comments

@feloy feloy feloy approved these changes

Assignees

@feloy feloy

Labels
lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Flake: namespace doesn't show up on interactive tests
5 participants
@anandrkskd @feloy @rm3l @valaparthvi @openshift-merge-robot