Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower log level for kclient.GetAllResourcesFromSelector #6360

Merged

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Nov 30, 2022

What type of PR is this:

/kind bug

What does this PR do / why we need it:

This PR lower log levels for the kclient.GetAllResourcesFromSelector fucntion.

These levels have been imported from the original source code (https://github.com/ahmetb/kubectl-tree) but are not correct for odo level policy, and they spam the tests output.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Nov 30, 2022
@openshift-ci openshift-ci bot requested review from anandrkskd and rm3l November 30, 2022 08:04
@netlify
Copy link

netlify bot commented Nov 30, 2022

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit a4efcf1
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/63870e7b741833000979566b

@feloy feloy requested review from valaparthvi and removed request for anandrkskd November 30, 2022 08:04
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

NoCluster Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 30, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 30, 2022
@rm3l rm3l added this to the v3.4.0 🚀 milestone Nov 30, 2022
@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

Kubernetes Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 30, 2022

OpenShift Tests on commit finished with errors.
View logs: TXT HTML

@feloy
Copy link
Contributor Author

feloy commented Nov 30, 2022

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test:

odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
  when component is created and odo logs is executed
  /go/odo_1/tests/integration/cmd_logs_test.go:69
    when running in Deploy mode
    /go/odo_1/tests/integration/cmd_logs_test.go:129
      [It] should successfully show logs of the running component
      /go/odo_1/tests/integration/cmd_logs_test.go:136

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

Flaky test:

odo logs command tests
/go/odo_1/tests/integration/cmd_logs_test.go:14
 when component is created and odo logs is executed
 /go/odo_1/tests/integration/cmd_logs_test.go:69
   when running in Deploy mode
   /go/odo_1/tests/integration/cmd_logs_test.go:129
     [It] should successfully show logs of the running component
     /go/odo_1/tests/integration/cmd_logs_test.go:136

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Nov 30, 2022

/override ci/prow/v4.11-integration-e2e
Flaky e2e test failing

@openshift-ci
Copy link

openshift-ci bot commented Nov 30, 2022

@feloy: Overrode contexts on behalf of feloy: ci/prow/v4.11-integration-e2e

In response to this:

/override ci/prow/v4.11-integration-e2e
Flaky e2e test failing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit bf6a04b into redhat-developer:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants