Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dharmit from OWNERS files across the repo #6320

Merged
merged 3 commits into from
Nov 21, 2022
Merged

Remove Dharmit from OWNERS files across the repo #6320

merged 3 commits into from
Nov 21, 2022

Conversation

dharmit
Copy link
Member

@dharmit dharmit commented Nov 18, 2022

Signed-off-by: Dharmit Shah [email protected]

@openshift-ci openshift-ci bot requested review from feloy and valaparthvi November 18, 2022 12:43
@netlify
Copy link

netlify bot commented Nov 18, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit bfdee8d
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/637b58355e172b00077272d2
😎 Deploy Preview https://deploy-preview-6320--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

NoCluster Tests on commit 41eae49 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

Unit Tests on commit 41eae49 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

Validate Tests on commit 41eae49 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

Kubernetes Tests on commit 41eae49 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

Windows Tests (OCP) on commit 41eae49 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Nov 18, 2022 •
edited
Loading

OpenShift Tests on commit 41eae49 finished successfully.
View logs: TXT HTML

@rm3l rm3l added this to the v3.3.0 🚀 milestone Nov 18, 2022
valaparthvi
valaparthvi suggested changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hate these sad PRs. :/

But, while you're at it, can you also update docs/website/OWNERS and docs/OWNERS?

rm3l
rm3l reviewed Nov 21, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dharmit for your work on odo!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Nov 21, 2022
rm3l
rm3l approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Nov 21, 2022
@dharmit
Copy link
Member Author

dharmit commented Nov 21, 2022

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Nov 21, 2022

@dharmit: Overrode contexts on behalf of dharmit: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit d1d7cce into redhat-developer:main Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@valaparthvi valaparthvi valaparthvi approved these changes

@feloy feloy Awaiting requested review from feloy

Assignees

@rm3l rm3l

@valaparthvi valaparthvi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
v3.3.0 🚀
Development

Successfully merging this pull request may close these issues.
4 participants
@dharmit @rm3l @valaparthvi @openshift-merge-robot