Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link to advanced guide in quickstart guides #6228

Merged
merged 1 commit into from
Oct 18, 2022
Merged

Add a link to advanced guide in quickstart guides #6228

merged 1 commit into from
Oct 18, 2022

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:
/kind feature
/area documentation

What does this PR do / why we need it:
This PR adds link of advanced guide in the relevant quickstart guides.
Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation label Oct 17, 2022
@netlify
Copy link

netlify bot commented Oct 17, 2022 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 5b59dae
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/634e1d063ddcaf000966d207

@openshift-ci openshift-ci bot added the area/documentation Issues or PRs related to documentation or the 'odo.dev' website label Oct 17, 2022
@openshift-ci openshift-ci bot requested review from feloy and kadel October 17, 2022 06:08
@odo-robot
Copy link

odo-robot bot commented Oct 17, 2022 •
edited
Loading

Unit Tests on commit 0fbc4a1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 17, 2022 •
edited
Loading

Validate Tests on commit 0fbc4a1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 17, 2022 •
edited
Loading

Kubernetes Tests on commit 0fbc4a1 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 17, 2022 •
edited
Loading

OpenShift Tests on commit 0fbc4a1 finished successfully.
View logs: TXT HTML

@openshift-ci
Copy link

openshift-ci bot commented Oct 17, 2022

@valaparthvi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v4.11-integration-e2e 410c917 link true /test v4.11-integration-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

rm3l
rm3l requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can you remove this unrelated file? tests/examples/source/devfiles/nodejs/devfile-deploy-routes.yaml

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 17, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 18, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Oct 18, 2022

Windows Tests (OCP) on commit 0fbc4a1 finished successfully.
View logs: TXT HTML

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 18, 2022
@openshift-merge-robot openshift-merge-robot merged commit eaa43cd into redhat-developer:main Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

@feloy feloy Awaiting requested review from feloy

@kadel kadel Awaiting requested review from kadel

Assignees

@rm3l rm3l

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/feature Categorizes issue as a feature request. For PRs, that means that the PR is the implementation lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valaparthvi @rm3l @openshift-merge-robot