Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links in the installation guide #6214

Conversation

valaparthvi
Copy link
Contributor

Signed-off-by: Parthvi Vala [email protected]

What type of PR is this:
/kind bug
/area documentation

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@netlify
Copy link

netlify bot commented Oct 12, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit 8923b47
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/6346c10bd937fb00084ba2fc
😎 Deploy Preview https://deploy-preview-6214--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@openshift-ci openshift-ci bot added kind/bug Categorizes issue or PR as related to a bug. area/documentation Issues or PRs related to documentation or the 'odo.dev' website labels Oct 12, 2022
@openshift-ci openshift-ci bot requested review from cdrage and kadel October 12, 2022 13:28
@valaparthvi valaparthvi requested review from feloy and removed request for kadel and cdrage October 12, 2022 13:28
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Unit Tests on commit finished successfully.
View logs: TXT HTML

@feloy
Copy link
Contributor

feloy commented Oct 12, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Oct 12, 2022
@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Oct 12, 2022
@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Windows Tests (OCP) on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Validate Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

OpenShift Tests on commit finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Oct 12, 2022

Kubernetes Tests on commit finished with errors.
View logs: TXT HTML

@rm3l
Copy link
Member

rm3l commented Oct 12, 2022

✓  Creating kind ServiceBinding 
       ⚠  Pod is Pending
       ✓  Pod is Running
      Error occurred on Push - watch command was unable to push component: some servicebindings are not injected

Investigating why this is happening, but overriding this check in this PR because it is only related to the doc.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2022

@rm3l: Overrode contexts on behalf of rm3l: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

✓  Creating kind ServiceBinding 
      ⚠  Pod is Pending
      ✓  Pod is Running
     Error occurred on Push - watch command was unable to push component: some servicebindings are not injected

Investigating why this is happening, but overriding this check in this PR because it is only related to the doc.

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 40eb0a6 into redhat-developer:main Oct 12, 2022
rm3l added a commit to rm3l/odo that referenced this pull request Dec 1, 2022
rm3l added a commit to rm3l/odo that referenced this pull request Dec 5, 2022
rm3l added a commit to rm3l/odo that referenced this pull request Dec 6, 2022
rm3l added a commit to rm3l/odo that referenced this pull request Dec 7, 2022
openshift-merge-robot pushed a commit that referenced this pull request Dec 7, 2022
* Revert "Fix broken links in the installation guide (#6214)"

This reverts commit 40eb0a6.

* Reorganize installation doc and update odo version in it

* List asdf [1] as a possible alternative installation method

[1] https://asdf-vm.com/

* Drop unused code from home page

* Show images of IDE plugins on home page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. area/documentation Issues or PRs related to documentation or the 'odo.dev' website kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants