Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI images / information on index page of odo.dev #6148

Merged

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Sep 20, 2022

Add CLI images / information on index page of odo.dev

What type of PR is this:

/kind documentation

What does this PR do / why we need it:

Updates the index page with information / details on the CLI with
previews of using odo init, dev and deploy.

Which issue(s) this PR fixes:

Fixes part of #6034

Signed-off-by: Charlie Drage [email protected]

@netlify
Copy link

netlify bot commented Sep 20, 2022

Deploy Preview for odo-docusaurus-preview ready!

Name Link
🔨 Latest commit b882cb2
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/632b03527d7e700009142ce1
😎 Deploy Preview https://deploy-preview-6148--odo-docusaurus-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Unit Tests on commit bd1a2b8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Validate Tests on commit bd1a2b8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

OpenShift Tests on commit bd1a2b8 finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Kubernetes Tests on commit bd1a2b8 finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 20, 2022

Windows Tests (OCP) on commit bd1a2b8 finished successfully.
View logs: TXT HTML

Copy link
Contributor

@valaparthvi valaparthvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it! ❤️ 💯

@valaparthvi
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 21, 2022
<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind documentation

**What does this PR do / why we need it:**

Updates the index page with information / details on the CLI with
previews of using odo init, dev and deploy.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes part of redhat-developer#6034

Signed-off-by: Charlie Drage <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 21, 2022
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - thanks.

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rm3l

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. label Sep 21, 2022
@valaparthvi
Copy link
Contributor

/lgtm
PR was rebased

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 21, 2022
@valaparthvi valaparthvi reopened this Sep 21, 2022
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@valaparthvi
Copy link
Contributor

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

I am overriding these tests for now since the change in the PR is unrelated. However I will continue to debug the flakes.

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

@valaparthvi: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • ``

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • netlify/odo-docusaurus-preview/deploy-preview
  • validator/Validate
  • windows-integration-test/Windows-test

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
/override windows-integration-test/Windows-test

I am overriding these tests for now since the change in the PR is unrelated. However I will continue to debug the flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

In response to this:

/override Kubernetes-Integration-Tests/Kubernetes-Integration-Tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@valaparthvi
Copy link
Contributor

/override windows-integration-test/Windows-test

@openshift-ci
Copy link

openshift-ci bot commented Sep 21, 2022

@valaparthvi: Overrode contexts on behalf of valaparthvi: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit 1cbcc7f into redhat-developer:main Sep 21, 2022
kadel pushed a commit to kadel/odo that referenced this pull request Oct 3, 2022
…er#6148)

<!--
Thank you for opening a PR! Here are some things you need to know before submitting:

1. Please read our developer guideline: https://github.com/redhat-developer/odo/wiki/Dev:-odo-Dev-Guidelines
2. Label this PR accordingly with the '/kind' line
3. Ensure you have written and ran the appropriate tests: https://github.com/redhat-developer/odo/wiki/Dev:-Writing-and-running-tests
4. Read how we approve and LGTM each PR: https://github.com/redhat-developer/odo/wiki/Pull-Requests:-Review-guideline

Documentation:

If you are pushing a change to documentation, please read: https://github.com/redhat-developer/odo/wiki/Documentation:-Contributing
-->

**What type of PR is this:**

<!--
Add one of the following kinds:
/kind bug
/kind feature
/kind cleanup
/kind tests

Feel free to use other [labels](https://github.com/redhat-developer/odo/labels) as needed. However one of the above labels must be present or the PR will not be reviewed. This instruction is for reviewers as well.
-->
/kind documentation

**What does this PR do / why we need it:**

Updates the index page with information / details on the CLI with
previews of using odo init, dev and deploy.

**Which issue(s) this PR fixes:**
<!--
Specifying the issue will automatically close it when this PR is merged
-->

Fixes part of redhat-developer#6034

Signed-off-by: Charlie Drage <[email protected]>

Signed-off-by: Charlie Drage <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. Required by Prow. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants